[jira] [Commented] (BIGTOP-620) Add test for dfsadmin commands

["Roman Shaposhnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291877#comment-13291877 ] 

Roman Shaposhnik commented on BIGTOP-620:
-----------------------------------------

Could you please update your patch to use Bigtop's Shell utility class? This is mainly to not expose the details of assuming a different user identity, instead:

{noformat}
static Shell shRoot = new Shell("/bin/bash", "root");
{noformat}

Let me know if you have any questions.

Oh, and does your test leave NN in a usable state?
                
> Add test for dfsadmin commands
> ------------------------------
>
>                 Key: BIGTOP-620
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-620
>             Project: Bigtop
>          Issue Type: Test
>    Affects Versions: 0.4.0
>            Reporter: Sujay Rau
>             Fix For: 0.4.0
>
>         Attachments: bigtop-620.patch
>
>
> Wrote a test that goes through the "hdfs dfsadmin -???" commands and makes sure no errors are returned as well as checking some functionality. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira