You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/06 05:36:31 UTC

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 opened a new pull request #290: Add Python logo in topo

kezhenxu94 opened a new pull request #290:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #290: Add Python logo in topo

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #290:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290#issuecomment-624488681


   Got it. But Python and its component ids have not been reserved in the `component-libraries.yml`. Please add it there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #290: Add Python logo in topo

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #290:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290#issuecomment-624493687


   > Got it. But Python and its component ids have not been reserved in the `component-libraries.yml`. Please add it there.
   
   It's already there for a while https://github.com/apache/skywalking/pull/4746


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #290: Add Python logo in topo

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #290:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290#issuecomment-624475309


   > Does python only need one icon rather than different libraries?
   
   This one is just for those libraries that are built in Python core (similar to JDK HTTP, Threading), that have no logos to display, for other libraries like Flask or Django, there will be their logos to display


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org