You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/03/20 16:42:09 UTC
Review Request 19466: Add batching to the kill and killall commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Brian Wickman.
Bugs: aurora-283
https://issues.apache.org/jira/browse/aurora-283
Repository: aurora
Description
-------
Add batching to the kill and killall commands.
(Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
Diffs
-----
src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
Diff: https://reviews.apache.org/r/19466/diff/
Testing
-------
[sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.37 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.47 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.43 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
=========================== 1 passed in 0.40 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.35 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
===================== 47 passed, 1 skipped in 3.57 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
========================== 20 passed in 0.25 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_updater.py ...........................
========================== 27 passed in 0.64 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_sla.py ...........................
========================== 27 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py ....
=========================== 4 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ......
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...
========================== 28 passed in 1.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=========================== 2 passed in 0.51 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=========================== 3 passed in 0.49 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=========================== 2 passed in 0.50 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items
src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
========================== 13 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 26 passed in 1.31 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/commands/test_maintenance.py ....
=========================== 4 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.40 seconds ===========================
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
src.test.python.apache.aurora.client.cli.help ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
src.test.python.apache.aurora.client.commands.run ..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38150
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70114>
I thought so: you've asked for a specific list of instances to be killed. If there's one of them that we can't kill for some reason, I don't think that means we shouldn't even try to do the rest.
For example, you could have a scenario where you ask to kill shards 10-20; for some reason, 14 died on its own. Should we completely abort killing the other 9?
On one hand, it's a reasonable thing to say abort at the first error. But on the other, I think that killing as many of the requested shards as we can is probably closer to what the user actually wants. As long as we make sure to tell them what failed.
src/test/python/apache/aurora/client/cli/test_restart.py
<https://reviews.apache.org/r/19466/#comment70115>
Yes - I moved it into util.py, because it's used in both test_restart, and now in test_kill.
- Mark Chu-Carroll
On March 20, 2014, 11:42 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 11:42 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 21, 2014, 6:44 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 317
> > <https://reviews.apache.org/r/19466/diff/1/?file=529926#file529926line317>
> >
> > I hear your point. However, it would be a departure from other places where we use batching (considering the default of max_total_failures=0). I can't find any strong reasons against it apart from consistency reasons, so would be curious what others say.
>
> Mark Chu-Carroll wrote:
> Hmm.... would it be better if I added the max_total_failures option, and used that to determine whether a batched kill succeeds?
>
That's a great idea. This way our batched APIs would deliver a consistent experience throughout.
> On March 21, 2014, 6:44 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_restart.py, line 43
> > <https://reviews.apache.org/r/19466/diff/1/?file=529930#file529930line43>
> >
> > Right, my comment was about the method in this class that still uses the old reference?
>
> Mark Chu-Carroll wrote:
> It's still accessible as "self.setup_get_task_status_calls". All of the tests inherit from AuroraClientCommandTest, where I moved it.
Ah, good to know.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38154
-----------------------------------------------------------
On March 21, 2014, 6:58 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 6:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
> On March 21, 2014, 2:44 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_restart.py, line 43
> > <https://reviews.apache.org/r/19466/diff/1/?file=529930#file529930line43>
> >
> > Right, my comment was about the method in this class that still uses the old reference?
It's still accessible as "self.setup_get_task_status_calls". All of the tests inherit from AuroraClientCommandTest, where I moved it.
> On March 21, 2014, 2:44 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 317
> > <https://reviews.apache.org/r/19466/diff/1/?file=529926#file529926line317>
> >
> > I hear your point. However, it would be a departure from other places where we use batching (considering the default of max_total_failures=0). I can't find any strong reasons against it apart from consistency reasons, so would be curious what others say.
Hmm.... would it be better if I added the max_total_failures option, and used that to determine whether a batched kill succeeds?
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38154
-----------------------------------------------------------
On March 20, 2014, 11:42 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 11:42 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38154
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70117>
I hear your point. However, it would be a departure from other places where we use batching (considering the default of max_total_failures=0). I can't find any strong reasons against it apart from consistency reasons, so would be curious what others say.
src/test/python/apache/aurora/client/cli/test_restart.py
<https://reviews.apache.org/r/19466/#comment70120>
Right, my comment was about the method in this class that still uses the old reference?
- Maxim Khutornenko
On March 20, 2014, 3:42 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 3:42 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38381
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70471>
You don't need [] in within set()
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70473>
I thought you were going with the max_total_failures approach, did you change your mind?
- Maxim Khutornenko
On March 21, 2014, 6:58 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 6:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38401
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70532>
I would add something like: "max_allowed:%s, actual errors:%s"
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70534>
Unrelated: why do we have --rollback-on-failure in restart command?
- Maxim Khutornenko
On March 24, 2014, 11:21 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 11:21 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4
> src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/
-----------------------------------------------------------
(Updated March 25, 2014, 7:24 p.m.)
Review request for Aurora, Maxim Khutornenko and Brian Wickman.
Changes
-------
rebase to master.
Bugs: aurora-283
https://issues.apache.org/jira/browse/aurora-283
Repository: aurora
Description
-------
Add batching to the kill and killall commands.
(Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/context.py c07f54a1838f88efcc59b3ff3f58c4148a2d79a0
src/main/python/apache/aurora/client/cli/jobs.py 290a8bab9bce901f8ec00adf45b184ac68de3eac
src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf
src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046
src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
Diff: https://reviews.apache.org/r/19466/diff/
Testing
-------
[sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.37 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.47 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.43 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
=========================== 1 passed in 0.40 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.35 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
===================== 47 passed, 1 skipped in 3.57 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
========================== 20 passed in 0.25 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_updater.py ...........................
========================== 27 passed in 0.64 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_sla.py ...........................
========================== 27 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py ....
=========================== 4 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ......
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...
========================== 28 passed in 1.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=========================== 2 passed in 0.51 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=========================== 3 passed in 0.49 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=========================== 2 passed in 0.50 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items
src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
========================== 13 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 26 passed in 1.31 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/commands/test_maintenance.py ....
=========================== 4 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.40 seconds ===========================
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
src.test.python.apache.aurora.client.cli.help ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
src.test.python.apache.aurora.client.commands.run ..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38489
-----------------------------------------------------------
Brian, ping?
- Mark Chu-Carroll
On March 24, 2014, 7:21 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 7:21 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4
> src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38543
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On March 24, 2014, 11:21 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 11:21 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4
> src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38484
-----------------------------------------------------------
Brian, ping?
- Mark Chu-Carroll
On March 24, 2014, 7:21 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 7:21 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4
> src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/
-----------------------------------------------------------
(Updated March 24, 2014, 7:21 p.m.)
Review request for Aurora, Maxim Khutornenko and Brian Wickman.
Changes
-------
Upload to the right review.
Bugs: aurora-283
https://issues.apache.org/jira/browse/aurora-283
Repository: aurora
Description
-------
Add batching to the kill and killall commands.
(Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4
src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf
src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046
src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
Diff: https://reviews.apache.org/r/19466/diff/
Testing
-------
[sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.37 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.47 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.43 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
=========================== 1 passed in 0.40 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.35 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
===================== 47 passed, 1 skipped in 3.57 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
========================== 20 passed in 0.25 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_updater.py ...........................
========================== 27 passed in 0.64 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_sla.py ...........................
========================== 27 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py ....
=========================== 4 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ......
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...
========================== 28 passed in 1.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=========================== 2 passed in 0.51 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=========================== 3 passed in 0.49 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=========================== 2 passed in 0.50 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items
src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
========================== 13 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 26 passed in 1.31 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/commands/test_maintenance.py ....
=========================== 4 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.40 seconds ===========================
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
src.test.python.apache.aurora.client.cli.help ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
src.test.python.apache.aurora.client.commands.run ..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38387
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70485>
I did. I screwed up again, uploaded the change to the wrong review. Stupid. I get completely screwed up when I try to juggle too many open reviews at once. Sorry.
- Mark Chu-Carroll
On March 21, 2014, 2:58 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 2:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38379
-----------------------------------------------------------
ping?
- Mark Chu-Carroll
On March 21, 2014, 2:58 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 2:58 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/
-----------------------------------------------------------
(Updated March 21, 2014, 2:58 p.m.)
Review request for Aurora, Maxim Khutornenko and Brian Wickman.
Changes
-------
Addressing some review comments:
- Got rid of an unnoticed error case, where an empty shard list would cause a crash.
- Added a new test case to catch that.
Bugs: aurora-283
https://issues.apache.org/jira/browse/aurora-283
Repository: aurora
Description
-------
Add batching to the kill and killall commands.
(Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32
src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4
src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
Diff: https://reviews.apache.org/r/19466/diff/
Testing
-------
[sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.37 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.47 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.43 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
=========================== 1 passed in 0.40 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.35 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
===================== 47 passed, 1 skipped in 3.57 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
========================== 20 passed in 0.25 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_updater.py ...........................
========================== 27 passed in 0.64 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_sla.py ...........................
========================== 27 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py ....
=========================== 4 passed in 0.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 28 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ......
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...
========================== 28 passed in 1.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_plugins.py ..
=========================== 2 passed in 0.51 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 3 items
src/test/python/apache/aurora/client/cli/test_quota.py ...
=========================== 3 passed in 0.49 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .....
=========================== 5 passed in 0.52 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=========================== 2 passed in 0.50 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 13 items
src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
========================== 13 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 26 passed in 1.31 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/commands/test_maintenance.py ....
=========================== 4 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.41 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.40 seconds ===========================
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
src.test.python.apache.aurora.client.cli.help ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
src.test.python.apache.aurora.client.commands.run ..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19466: Add batching to the kill and killall commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38140
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/19466/#comment70106>
s/thejob/the job/
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70108>
This will fail if there are no tasks to kill.
Also, drop [].
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70109>
Is there any reason to continue with a kill if a batch fails?
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/19466/#comment70110>
Same as above, iteration will fail if get_job_status returns None.
src/test/python/apache/aurora/client/cli/test_restart.py
<https://reviews.apache.org/r/19466/#comment70112>
Confused. Isn't it still called from setup_mock_scheduler_for_simple_restart?
- Maxim Khutornenko
On March 20, 2014, 3:42 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19466/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 3:42 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>
>
> Bugs: aurora-283
> https://issues.apache.org/jira/browse/aurora-283
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add batching to the kill and killall commands.
>
> (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe
> src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1
> src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6
> src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196
> src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa
> src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953
> src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8
>
> Diff: https://reviews.apache.org/r/19466/diff/
>
>
> Testing
> -------
>
> [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> =========================== 2 passed in 0.37 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ......
>
> =========================== 6 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
>
> =========================== 6 passed in 0.43 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> =========================== 1 passed in 0.40 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>
> =========================== 6 passed in 0.35 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
>
> ===================== 47 passed, 1 skipped in 3.57 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
>
> ========================== 20 passed in 0.25 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
>
> ========================== 27 passed in 0.64 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
>
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_sla.py ...........................
>
> ========================== 27 passed in 0.26 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
>
> =========================== 4 passed in 0.03 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_help.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 28 items
>
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ......
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
>
> ========================== 28 passed in 1.66 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
>
> =========================== 2 passed in 0.51 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
>
> src/test/python/apache/aurora/client/cli/test_quota.py ...
>
> =========================== 3 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
>
> src/test/python/apache/aurora/client/cli/test_sla.py .....
>
> =========================== 5 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
>
> =========================== 2 passed in 0.50 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
>
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
>
> ========================== 13 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================== 26 passed in 1.31 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
>
> =========================== 4 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_run.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/commands/test_ssh.py .
>
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
>
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>
> ========================== 12 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
>
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
>
> =========================== 4 passed in 0.40 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
> src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
> src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
> src.test.python.apache.aurora.client.api.sla ..... SUCCESS
> src.test.python.apache.aurora.client.api.updater ..... SUCCESS
> src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
> src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS
> src.test.python.apache.aurora.client.cli.help ..... SUCCESS
> src.test.python.apache.aurora.client.cli.job ..... SUCCESS
> src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
> src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
> src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
> src.test.python.apache.aurora.client.cli.task ..... SUCCESS
> src.test.python.apache.aurora.client.commands.admin ..... SUCCESS
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
> src.test.python.apache.aurora.client.commands.run ..... SUCCESS
> src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
> src.test.python.apache.aurora.client.config ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>