You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/02 00:22:22 UTC

[kudu-CR] KUDU-1557. maintenance manager: return most recently completed ops first 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4296

to review the following change.

Change subject: KUDU-1557. maintenance_manager: return most recently completed ops first
......................................................................

KUDU-1557. maintenance_manager: return most recently completed ops first

This changes the order of maintenance manager operations in the
maintenance manager status dump so that the most recently completed
operation is first in the list.

Change-Id: I7783bc8cee1beb0f7accaedbd46fb1e3a49168cc
---
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
2 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/4296/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7783bc8cee1beb0f7accaedbd46fb1e3a49168cc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] KUDU-1557. maintenance manager: return most recently completed ops first

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1557. maintenance_manager: return most recently completed ops first
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3197/

-- 
To view, visit http://gerrit.cloudera.org:8080/4296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7783bc8cee1beb0f7accaedbd46fb1e3a49168cc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1557. maintenance manager: return most recently completed ops first

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-1557. maintenance_manager: return most recently completed ops first
......................................................................


KUDU-1557. maintenance_manager: return most recently completed ops first

This changes the order of maintenance manager operations in the
maintenance manager status dump so that the most recently completed
operation is first in the list.

Change-Id: I7783bc8cee1beb0f7accaedbd46fb1e3a49168cc
Reviewed-on: http://gerrit.cloudera.org:8080/4296
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
2 files changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7783bc8cee1beb0f7accaedbd46fb1e3a49168cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1557. maintenance manager: return most recently completed ops first

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1557. maintenance_manager: return most recently completed ops first
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7783bc8cee1beb0f7accaedbd46fb1e3a49168cc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No