[jira] [Commented] (FLINK-15546) Obscure error message from ScalarOperatorGens::generateCast

["Zhenghua Gao (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014818#comment-17014818 ] 

Zhenghua Gao commented on FLINK-15546:
--------------------------------------

{code:java}
case (from, to) =>
  throw new CodeGenException(s"Unsupported cast from '$from' to '$to'.")
{code}
I think we should use *operand.resultType* and *targetType* instead in the error message since from and to are *LogicalTypeRoot*
 

> Obscure error message from ScalarOperatorGens::generateCast
> -----------------------------------------------------------
>
>                 Key: FLINK-15546
>                 URL: https://issues.apache.org/jira/browse/FLINK-15546
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: Rui Li
>            Priority: Minor
>
> Consider the following case:
> {noformat}
> Flink SQL> describe foo;
> root
>  |-- x: ROW<`f1` DOUBLE, `f2` VARCHAR(10)>
> Flink SQL> insert into foo select row(1.1,'abc');
> [INFO] Submitting SQL update statement to the cluster...
> [ERROR] Could not execute SQL statement. Reason:
> org.apache.flink.table.planner.codegen.CodeGenException: Unsupported cast from 'ROW' to 'ROW'.
> {noformat}
> Users are unlikely to figure out what goes wrong from the above error message. Something like {{Unsupported cast from 'ROW<DECIMAL(2,1), CHAR(3)>' to 'ROW<DOUBLE, VARCHAR(10)>'}} will be more helpful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)