[GitHub] [incubator-doris] morningman commented on a change in pull request #2097: Fix explain InsertStmt NPE in FOLLOWER node

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2097: Fix explain InsertStmt NPE in FOLLOWER node
URL: https://github.com/apache/incubator-doris/pull/2097#discussion_r340547837
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java
 ##########
 @@ -762,4 +762,13 @@ public void reset() {
         dataPartition = null;
         targetColumns.clear();
     }
+
+    @Override
+    public RedirectStatus getRedirectStatus() {
+        if (isExplain()) {
+            return null;
+        } else {
+            return RedirectStatus.FORWARD_WITH_SYNC;
 
 Review comment:
   I think `FORWARD_NO_SYNC` is enough. Explain Insert does not modify any meta data that need to be sync.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org