[GitHub] [myfaces] volosied commented on a diff in pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

[GitBox <gi...@apache.org>]

volosied commented on code in PR #492:
URL: https://github.com/apache/myfaces/pull/492#discussion_r1082861220


##########
impl/src/main/java/org/apache/myfaces/renderkit/RendererUtils.java:
##########
@@ -693,17 +693,25 @@ else if (allowNonArrayOrCollectionValue)
     public static Object getConvertedUISelectOneValue(
             FacesContext facesContext, UISelectOne output, Object submittedValue)
     {
-        if (submittedValue != null && !(submittedValue instanceof String))
+
+        if(submittedValue == null)
+        {
+            if (log.isLoggable(Level.FINE))
+            {
+                log.fine("No conversion necessary for null uiselectone value: client id " + output.getClientId());
+            }
+            return null;

Review Comment:
   Mojarra returns null and so I did the same here ( since no value is submitted)
   
   I'm just not sure if this is correct, however. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org