[GitHub] [arrow] lidavidm commented on a diff in pull request #13109: ARROW-15365: [Python] Expose full cast options in the pyarrow.compute.cast function

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #13109:
URL: https://github.com/apache/arrow/pull/13109#discussion_r871757065


##########
python/pyarrow/array.pxi:
##########
@@ -895,7 +895,7 @@ cdef class Array(_PandasConvertible):
             result = self.ap.Diff(deref(other.ap))
         return frombytes(result, safe=True)
 
-    def cast(self, object target_type, safe=True):
+    def cast(self, object target_type, safe=True, options=None):

Review Comment:
   The redundancy between `safe` and `options` isn't great. I wonder if we can have `safe=None`, and then raise an exception if passing both `safe` and `options`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org