You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/13 03:38:55 UTC
[GitHub] kevcampb opened a new pull request #3743: [AIRFLOW-2799] Filtering
UI objects by datetime is broken
kevcampb opened a new pull request #3743: [AIRFLOW-2799] Filtering UI objects by datetime is broken
URL: https://github.com/apache/incubator-airflow/pull/3743
This change treats the datetimes supplied by the UI as being in UTC. This only
works correctly where the system is using UTC throughout, but is an improvement
over the current behavior (crash).
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2799
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
Yes there is a description
### Tests
No tests as this involves UI code.
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
Not required
### Code Quality
- [No] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
utils.py never passed flake8 in the first place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services