[jira] [Commented] (CASSANDRA-12516) Interned column identifiers can be overridden incorrectly

["Stefania (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482775#comment-15482775 ] 

Stefania commented on CASSANDRA-12516:
--------------------------------------

Patch here, CI still pending:

||3.0||trunk||
|[patch|https://github.com/stef1927/cassandra/commits/12516-3.0]|[patch|https://github.com/stef1927/cassandra/commits/12516]|
|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-testall/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12516-dtest/]|


> Interned column identifiers can be overridden incorrectly
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-12516
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12516
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Stefania
>             Fix For: 3.0.x, 3.x
>
>
> As discovered by [~Stefania] in CASSANDRA-12423, our use of {{ColumnIdentifier.internedInstances}} to map byte buffer column names to column identifiers is incorrect. It's possible for two non-equal {{ColumnIdentifier}} instances to have the same {{ByteBuffer}} as raw name, and yet different text representations, due to different column name types, leading to hard to debug correctness issues.
> Should either amend the map to have the type as part of the key, or limit the use of that map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)