[GitHub] [ignite] dmagda commented on a change in pull request #6486: IGNITE-11771: adding the option to include pods with a not-ready state

[GitBox <gi...@apache.org>]

dmagda commented on a change in pull request #6486: IGNITE-11771: adding the option to include pods with a not-ready state
URL: https://github.com/apache/ignite/pull/6486#discussion_r293120191
 
 

 ##########
 File path: modules/kubernetes/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/kubernetes/TcpDiscoveryKubernetesIpFinder.java
 ##########
 @@ -227,6 +233,15 @@ public void setAccountToken(String accountToken) {
         this.accountToken = accountToken;
     }
 
+    /**
+     * Determines whether addresses of not-ready pods should be included. Default is false.
+     *
+     * @param includeNotReadyAddresses Flag to include not-ready pods.
+     */
+    public void setIncludeNotReadyAddresses(boolean includeNotReadyAddresses) {
 
 Review comment:
   Please rename to "includeNotReadyAddresses" to follow Ignite-naming convention. Plus, I would have this option enabled by default to avoid any issues with existing deployments. Our discovery SPI does several connection attempts and some of the pods might be ready by that time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services