[GitHub] [flink] Myasuka commented on a diff in pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

[GitBox <gi...@apache.org>]

Myasuka commented on code in PR #21729:
URL: https://github.com/apache/flink/pull/21729#discussion_r1080950829


##########
flink-python/pyflink/datastream/state_backend.py:
##########
@@ -956,16 +956,20 @@ class PredefinedOptions(Enum):
     determined to be beneficial for performance under different settings.
 
     Some of these settings are based on experiments by the Flink community, some follow
-    guides from the RocksDB project.
+    guides from the RocksDB project. Some configurations are enabled unconditionally (e.g.
+    setUseFsync(false), which disables syncing to storage) so they do not appear here. See the
+    documentation for the createBaseCommonDBOptions() and createBaseCommonColumnOptions() methods

Review Comment:
   `createBaseCommonDBOptions` and `createBaseCommonColumnOptions` is not public in `RocksDBResourceContainer`. I think we don't need to emphasize this.



##########
flink-python/pyflink/datastream/state_backend.py:
##########
@@ -1000,21 +1000,24 @@ class PredefinedOptions(Enum):
 
     The following options are set:
 
+    - BlockBasedTableConfig.setBlockCacheSize(256 MBytes)
+    - BlockBasedTableConfig.setBlockSize(128 KBytes)
+    - BlockBasedTableConfig.setFilterPolicy(BloomFilter(
+        `BLOOM_FILTER_BITS_PER_KEY`,
+        `BLOOM_FILTER_BLOCK_BASED_MODE`)
     - setLevelCompactionDynamicLevelBytes(true)
-    - setTargetFileSizeBase(256 MBytes)
+    - setMaxBackgroundJobs(4)
     - setMaxBytesForLevelBase(1 GByte)
-    - setWriteBufferSize(64 MBytes)
-    - setIncreaseParallelism(4)
-    - setMinWriteBufferNumberToMerge(3)
-    - setMaxWriteBufferNumber(4)
-    - setUseFsync(false)
     - setMaxOpenFiles(-1)
-    - BlockBasedTableConfig.setBlockCacheSize(256 MBytes)
-    - BlockBasedTableConfigsetBlockSize(128 KBytes)
+    - setMaxWriteBufferNumber(4)

Review Comment:
   Why we need to change the orders of these settings in this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org