[GitHub] [storm] agresch commented on a change in pull request #3292: STORM-3656 handle worker NPE from Hadoop auto renewal thread

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3292:
URL: https://github.com/apache/storm/pull/3292#discussion_r445140225



##########
File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java
##########
@@ -1020,11 +1049,26 @@ public static UncaughtExceptionHandler createDefaultUncaughtExceptionHandler() {
             }
         };
     }
-    
+
+    public static UncaughtExceptionHandler createWorkerUncaughtExceptionHandler() {
+        return (thread, thrown) -> {
+            try {
+                handleWorkerUncaughtException(thrown);
+            } catch (Error err) {
+                LOG.error("Received error in thread {}.. terminating worker...", thread.getName(), err);
+                Runtime.getRuntime().exit(-2);

Review comment:
       I was just following createDefaultUncaughtExceptionHandler().  If you feel this should change, I would prefer to work as a separate JIRA.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org