You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/09/20 04:07:47 UTC
[GitHub] spark pull request #22481: Revert [SPARK-19355][SPARK-25352]
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/22481
Revert [SPARK-19355][SPARK-25352]
## What changes were proposed in this pull request?
This goes to revert sequential PRs based on some discussion and comments at https://github.com/apache/spark/pull/16677#issuecomment-422650759.
#22344
#22330
#22239
#16677
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 revert-SPARK-19355-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22481.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22481
----
commit 7b81a95e9496ba953648880a70896085e2bfd043
Author: Liang-Chi Hsieh <vi...@...>
Date: 2018-09-20T03:14:50Z
Revert "[SPARK-25352][SQL] Perform ordered global limit when limit number is bigger than topKSortFallbackThreshold"
This reverts commit 2f422398b524eacc89ab58e423bb134ae3ca3941.
commit cea66899194f19812ac217cde2d8b6fe1fbe1328
Author: Liang-Chi Hsieh <vi...@...>
Date: 2018-09-20T03:57:38Z
Revert "[SPARK-19355][SQL][FOLLOWUP][TEST] Properly recycle SparkSession on TakeOrderedAndProjectSuite finishes"
This reverts commit 3aa60282cc84d471ea32ef240ec84e5b6e3e231b.
commit 2dae33e5b897c0ec05f675ec565abee5f2c4ea34
Author: Liang-Chi Hsieh <vi...@...>
Date: 2018-09-20T03:58:11Z
Revert "[SPARK-19355][SQL][FOLLOWUP] Remove the child.outputOrdering check in global limit"
This reverts commit 5c27b0d4f8d378bd7889d26fb358f478479b9996.
commit 4532aaa2471c04c57f3b59bdcec26ad83627df68
Author: Liang-Chi Hsieh <vi...@...>
Date: 2018-09-20T04:00:46Z
Revert "[SPARK-19355][SQL] Use map output statistics to improve global limit's parallelism"
This reverts commit 4f175850985cfc4c64afb90d784bb292e81dc0b7.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22481
LGTM, thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3286/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22481: Revert [SPARK-19355][SPARK-25352]
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22481
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22481
thanks, merging to master/2.4!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22481
**[Test build #96332 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96332/testReport)** for PR 22481 at commit [`4532aaa`](https://github.com/apache/spark/commit/4532aaa2471c04c57f3b59bdcec26ad83627df68).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22481
**[Test build #96320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96320/testReport)** for PR 22481 at commit [`4532aaa`](https://github.com/apache/spark/commit/4532aaa2471c04c57f3b59bdcec26ad83627df68).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96332/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22481
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22481
cc @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22481
**[Test build #96332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96332/testReport)** for PR 22481 at commit [`4532aaa`](https://github.com/apache/spark/commit/4532aaa2471c04c57f3b59bdcec26ad83627df68).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait BaseLimitExec extends UnaryExecNode with CodegenSupport `
* `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22481
**[Test build #96320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96320/testReport)** for PR 22481 at commit [`4532aaa`](https://github.com/apache/spark/commit/4532aaa2471c04c57f3b59bdcec26ad83627df68).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait BaseLimitExec extends UnaryExecNode with CodegenSupport `
* `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3288/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96320/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3279/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org