[GitHub] [incubator-hugegraph-computer] coderzc commented on a diff in pull request #237: fix: superstep not take effect

["coderzc (via GitHub)" <gi...@apache.org>]

coderzc commented on code in PR #237:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/237#discussion_r1188553522


##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/master/MasterService.java:
##########
@@ -335,9 +335,7 @@ private boolean finishedIteration(boolean masterContinue,
         if (context.superstep() >= this.maxSuperStep - 1) {
             return true;
         }
-        long activeVertexCount = context.totalVertexCount() -
-                                 context.finishedVertexCount();
-        return context.messageCount() == 0L && activeVertexCount == 0L;
+        return false;

Review Comment:
   I think the root case is `messageCount` always is 0, see: https://github.com/apache/incubator-hugegraph-computer/blob/3328d5232ab944143d60fc4dc946d566550fa6e8/computer-core/src/main/java/org/apache/hugegraph/computer/core/receiver/MessageRecvPartition.java#L130-L133
   
   so I think we should use `messageBytes` instead of `messageCount`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org