You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:53:58 UTC

[GitHub] [curator] eolivelli commented on pull request #384: CURATOR-592 Initial commit, no enough tests

eolivelli commented on pull request #384:
URL: https://github.com/apache/curator/pull/384#issuecomment-860383519


   @MGelbana-Incorta 
   
   I found the description of the purpose of this change in https://issues.apache.org/jira/browse/CURATOR-592
   probably for the future it is better to make a brief summary in the description of the PR and set the Title accordingly.
   
   Apart from that....
   I see that you say that this change is still not ready to be useful.
   
   As @Randgalt comments this code is much complex and it is hard to add this feature in a way that we can provide a consistent behaviour (at least without introducing many changes)
   
   Did you consider to create new classes ? not a "fork" maintained by yourself alone but new enhanced classes to be added here next to the existing recipes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org