You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/28 16:41:20 UTC
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #983: MINIFICPP-1464 synchronize LICENSE and msi/LICENSE.txt
szaszm opened a new pull request #983:
URL: https://github.com/apache/nifi-minifi-cpp/pull/983
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #983: MINIFICPP-1464 synchronize LICENSE and msi/LICENSE.txt
Posted by GitBox <gi...@apache.org>.
szaszm edited a comment on pull request #983:
URL: https://github.com/apache/nifi-minifi-cpp/pull/983#issuecomment-771666092
I also thought about it, but didn't want to delay the release with this issue. I can create a Jira issue to track this.
I made an attempt to convert msi/LICENSE.txt to a symlink, but on Windows it got checked out as a text file containing the link destination. Newer git versions should support symlinks, but I figured if it doesn't work everywhere (or anywhere by default), it's better to keep it copied as we don't want people accidentally generating MSIs with "../LICENSE" as their license text.
[[MINIFICPP-1496] Ensure that the MSI installer always shows LICENSE](https://issues.apache.org/jira/browse/MINIFICPP-1469)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #983: MINIFICPP-1464 synchronize LICENSE and msi/LICENSE.txt
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #983:
URL: https://github.com/apache/nifi-minifi-cpp/pull/983#issuecomment-771666092
I also thought about it, but didn't want to delay the release with this issue. I can create a Jira issue to track this.
I made an attempt to convert msi/LICENSE.txt to a symlink, but on Windows it got checked out as a text file containing the link destination. Newer git versions should support symlinks, but I figured if it doesn't work everywhere (or anywhere by default), it's better to keep it copied as we don't want people accidentally generating MSIs with "../LICENSE" as their license text.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #983: MINIFICPP-1464 synchronize LICENSE and msi/LICENSE.txt
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #983:
URL: https://github.com/apache/nifi-minifi-cpp/pull/983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #983: MINIFICPP-1464 synchronize LICENSE and msi/LICENSE.txt
Posted by GitBox <gi...@apache.org>.
szaszm edited a comment on pull request #983:
URL: https://github.com/apache/nifi-minifi-cpp/pull/983#issuecomment-771666092
I also thought about it, but didn't want to delay the release with this issue. I can create a Jira issue to track this.
I made an attempt to convert msi/LICENSE.txt to a symlink, but on Windows it got checked out as a text file containing the link destination. Newer git versions should support symlinks, but I figured if it doesn't work everywhere (or anywhere by default), it's better to keep it copied as we don't want people accidentally generating MSIs with "../LICENSE" as their license text.
[[MINIFICPP-1496] Ensure that the MSI installer always shows LICENSE](https://issues.apache.org/jira/browse/MINIFICPP-1469)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #983: MINIFICPP-1464 synchronize LICENSE and msi/LICENSE.txt
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #983:
URL: https://github.com/apache/nifi-minifi-cpp/pull/983#issuecomment-771666092
I also thought about it, but didn't want to delay the release with this issue. I can create a Jira issue to track this.
I made an attempt to convert msi/LICENSE.txt to a symlink, but on Windows it got checked out as a text file containing the link destination. Newer git versions should support symlinks, but I figured if it doesn't work everywhere (or anywhere by default), it's better to keep it copied as we don't want people accidentally generating MSIs with "../LICENSE" as their license text.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org