You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/05 21:24:48 UTC
[GitHub] [airflow] mik-laj opened a new pull request #15217: Remove TaskInstance.log_filepath attribute
mik-laj opened a new pull request #15217:
URL: https://github.com/apache/airflow/pull/15217
Continuation of: https://github.com/apache/airflow/pull/9084 (I transfer this PR to my private account)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #15217: Remove TaskInstance.log_filepath attribute
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15217:
URL: https://github.com/apache/airflow/pull/15217#issuecomment-846483753
Rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15217: Remove TaskInstance.log_filepath attribute
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15217:
URL: https://github.com/apache/airflow/pull/15217#issuecomment-817290938
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15217: Remove TaskInstance.log_filepath attribute
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15217:
URL: https://github.com/apache/airflow/pull/15217#issuecomment-815306021
@mik-laj CI is sad -- but I think if you rebase on Master, the tests should pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #15217: Remove TaskInstance.log_filepath attribute
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #15217:
URL: https://github.com/apache/airflow/pull/15217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15217: Remove TaskInstance.log_filepath attribute
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15217:
URL: https://github.com/apache/airflow/pull/15217#issuecomment-817264153
[The Workflow run](https://github.com/apache/airflow/actions/runs/737703003) is cancelling this PR. Building image for the PR has been cancelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15217: Remove TaskInstance.log_filepath attribute
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15217:
URL: https://github.com/apache/airflow/pull/15217#discussion_r609113821
##########
File path: UPDATING.md
##########
@@ -70,11 +70,21 @@ https://developers.google.com/style/inclusive-documentation
-->
+### Remove `TaskInstance.log_filepath` attribute
+
+This method returned incorrect values for a long time, because it did not take into account the different
+logger configuration and try retires. We're also starting to support more advanced tools that don't use
Review comment:
```suggestion
logger configuration and task retries. We have also started supporting more advanced tools that don't use
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org