You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/10 11:14:14 UTC

[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20508: Enable float32 data type in linalg cholesky test

mozga-intel opened a new pull request #20508:
URL: https://github.com/apache/incubator-mxnet/pull/20508


   ## Description ##
   Regarding #20505 . Running the Cholesky test on the current master uses only float64 data type. Checking Float32 data type is disabled. Is this intended or negligence? Here is a quick fix to check on float32 data type. 
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20508: Enable float32 data type in linalg cholesky test

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20508:
URL: https://github.com/apache/incubator-mxnet/pull/20508#issuecomment-895942772


   Hey @mozga-intel , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, clang, sanity, unix-cpu, centos-cpu, miscellaneous, windows-gpu, edge, centos-gpu, windows-cpu, unix-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20508: Enable float32 data type in linalg cholesky test

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20508:
URL: https://github.com/apache/incubator-mxnet/pull/20508#issuecomment-905347127


   Jenkins CI successfully triggered : [clang, unix-gpu, unix-cpu, centos-gpu, website, windows-cpu, edge, centos-cpu, windows-gpu, sanity, miscellaneous]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #20508: Enable float32 data type in linalg cholesky test

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20508:
URL: https://github.com/apache/incubator-mxnet/pull/20508#issuecomment-905515128


   Looks like the atol and rtol need to be adjusted for lower precision cholesky op.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20508: Enable float32 data type in linalg cholesky test

Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20508:
URL: https://github.com/apache/incubator-mxnet/pull/20508#issuecomment-905347043


   @mxnet-bot run ci [all]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org