You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/04/03 15:38:29 UTC

Re: Review Request 58010: GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58010/#review170882
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On March 30, 2017, 7:19 p.m., Patrick Rhomberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58010/
> -----------------------------------------------------------
> 
> (Updated March 30, 2017, 7:19 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added relevant unit and dUnit tests.  Moved default value variable to ExportLogsCommand and deleted the now-unused LogService.DEFAULT_LOG_LEVEL
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/logging/LogService.java 1f8a564 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java 3f147c1 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java cbdf1c4 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java 95edd42 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58010/diff/2/
> 
> 
> Testing
> -------
> 
> precheckin running.
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>