You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/26 05:12:12 UTC
[GitHub] [shardingsphere-elasticjob-lite] terrymanu opened a new issue #840: Add SQL dialect for event tracing storage
terrymanu opened a new issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840
The current event tracing storage use properties file to process SQL which to distinguish different SQL dialects.
MySQL, H2 properties have finished, SQL92 need to be polish.
The PostgreSQL, Oracle, SQLServer, DB2 are missing.
Developer can add properties in to `META-INF\sql` folder.
- [ ] Add `META-INF\sql\postgresql.properties` and provide correct SQL for PostgreSQL
- [ ] Add `META-INF\sql\oracle.properties` and provide correct SQL for Oracle
- [ ] Add `META-INF\sql\sqlserver.properties` and provide correct SQL for SQLServer
- [ ] Add `META-INF\sql\db2.properties` and provide correct SQL for DB2
- [ ] Update `META-INF\sql\sql92.properties` and provide correct SQL for SQL92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-652875003
> original_task_id
I can not decide because add field in index may cause insert slower. We need to have a performance test report to support our decision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] dhc575757 commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
dhc575757 commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-649974089
please assign to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] jiang2015 commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
jiang2015 commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-652831691
I will try postgresql,thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-649973659
@tianbin1001 Welcome
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] tianbin1001 commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
tianbin1001 commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-649973316
please assign to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] jiang2015 commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
jiang2015 commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-652865397
I think this sql [CREATE INDEX TASK_ID_STATE_INDEX ON JOB_STATUS_TRACE_LOG (task_id, state)];
it is better like this [CREATE INDEX TASK_ID_STATE_ORIGINAL_TASK_ID_INDEX ON JOB_STATUS_TRACE_LOG (task_id, state, original_task_id)]
for this sql [SELECT original_task_id FROM JOB_STATUS_TRACE_LOG WHERE task_id=? and state='TASK_STAGING' LIMIT 1]
[TASK_ID_STATE_ORIGINAL_TASK_ID_INDEX] using Covering index(覆盖索引), 避免二次回表查询, @terrymanu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-649977253
@dhc575757 Cool, assigned
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu closed issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] jiang2015 commented on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
jiang2015 commented on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-652906466
table [JOB_EXECUTION_LOG] column [is_success INT NOT NULL] I think in MYSQL: [is_success tinyint(1) NOT NULL] is better, IN JAVA class [JobExecutionEvent], [is_success] style is boolean, I test in my local , it is the same result. @terrymanu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu edited a comment on issue #840: Add SQL dialect for event tracing storage
Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #840:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/issues/840#issuecomment-652875003
I can not decide because add field in index may cause insert slower. We need to have a performance test report to support our decision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org