You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/04/18 18:11:57 UTC
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13065
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
The patch refactors the SentryProxy, which does Sentry cache
invalidation from CatalogServiceCatalog into a Sentry-specific
implementation, i.e. SentryCatalogdAuthorizationManager. This patch
also adds a new method in the AuthorizationManager interface to allow
refreshing authorization for any authorization provider that caches the
authorization metadata.
This patch also contains minor clean-up to address comments in this
abandoned CR: https://gerrit.cloudera.org/c/12748
This patch has no functionality change.
Testing:
- Ran all FE tests
- Ran all E2E authorization tests
Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
---
A fe/src/main/java/org/apache/impala/authorization/AuthorizationDelta.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationProvider.java
R fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java
M fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/java/org/apache/impala/common/FrontendFixture.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/java/org/apache/impala/common/QueryFixture.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/PlannerTestCaseLoader.java
29 files changed, 323 insertions(+), 186 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13065/2
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4048/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 16:44:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
The patch refactors the SentryProxy, which does Sentry cache
invalidation from CatalogServiceCatalog into a Sentry-specific
implementation, i.e. SentryCatalogdAuthorizationManager. This patch
also adds a new method in the AuthorizationManager interface to allow
refreshing authorization for any authorization provider that caches the
authorization metadata.
This patch also contains minor clean-up to address comments in this
abandoned CR: https://gerrit.cloudera.org/c/12748
This patch has no functionality change.
Testing:
- Ran all FE tests
- Ran all E2E authorization tests
Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
---
A fe/src/main/java/org/apache/impala/authorization/AuthorizationDelta.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationProvider.java
R fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java
M fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/java/org/apache/impala/common/FrontendFixture.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/java/org/apache/impala/common/QueryFixture.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/PlannerTestCaseLoader.java
29 files changed, 329 insertions(+), 188 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13065/3
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2836/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 18:50:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 16:44:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Refactor seems straightforward and makes sense to me. Thanks for breaking this up into a separate change. Definitely makes it easy for review.
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@128
PS3, Line 128: Performs a refresh authorization.
nit: Mention what it actually does?
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@130
PS3, Line 130: when the operation is INVALIDATE METADATA, resetVersions will be
: * set to true. That means the versions in the catalog objects
: * will need to be incremented.
nit: swap this? When resetVersions is true, object versions are not incremented. Used for INVALIDATE METADATA...
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@199
PS3, Line 199: // TODO: IMPALA-8293 (part 2)
: return new AuthorizationDelta();
nit: NotImplementedException...?
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 16:35:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Carry +2.
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@128
PS3, Line 128: Performs a refresh authorization
> nit: Mention what it actually does?
Done
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@130
PS3, Line 130: when resetVersions is true (used by INVALIDATE METADATA),
: * catalog object versions will need to be incremented.
: * @return {@link AuthorizationDelta} for the author
> nit: swap this? When resetVersions is true, object versions are not increme
Done
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@199
PS3, Line 199: // TODO: IMPALA-8293 (part 2)
: return new AuthorizationDelta();
> nit: NotImplementedException...?
Throwing an exception here will make `invalidate metadata` and `refresh authorization` broken when running with Ranger.
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 16:44:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
The patch refactors the SentryProxy, which does Sentry cache
invalidation from CatalogServiceCatalog into a Sentry-specific
implementation, i.e. SentryCatalogdAuthorizationManager. This patch
also adds a new method in the AuthorizationManager interface to allow
refreshing authorization for any authorization provider that caches the
authorization metadata.
This patch also contains minor clean-up to address comments in this
abandoned CR: https://gerrit.cloudera.org/c/12748
This patch has no functionality change.
Testing:
- Ran all FE tests
- Ran all E2E authorization tests
Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
---
A fe/src/main/java/org/apache/impala/authorization/AuthorizationDelta.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationProvider.java
R fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java
M fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/java/org/apache/impala/common/FrontendFixture.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/java/org/apache/impala/common/QueryFixture.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/PlannerTestCaseLoader.java
29 files changed, 328 insertions(+), 188 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13065/4
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2845/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 17:15:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2837/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 20:55:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
The patch refactors the SentryProxy, which does Sentry cache
invalidation from CatalogServiceCatalog into a Sentry-specific
implementation, i.e. SentryCatalogdAuthorizationManager. This patch
also adds a new method in the AuthorizationManager interface to allow
refreshing authorization for any authorization provider that caches the
authorization metadata.
This patch also contains minor clean-up to address comments in this
abandoned CR: https://gerrit.cloudera.org/c/12748
This patch has no functionality change.
Testing:
- Ran all FE tests
- Ran all E2E authorization tests
Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Reviewed-on: http://gerrit.cloudera.org:8080/13065
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A fe/src/main/java/org/apache/impala/authorization/AuthorizationDelta.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationProvider.java
R fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuditingTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java
M fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/java/org/apache/impala/common/FrontendFixture.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/java/org/apache/impala/common/QueryFixture.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/ImpaladTestCatalog.java
M fe/src/test/java/org/apache/impala/testutil/PlannerTestCaseLoader.java
29 files changed, 328 insertions(+), 188 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 21:49:45 +0000
Gerrit-HasComments: No