You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/13 18:15:08 UTC

[GitHub] [arrow] vertexclique opened a new pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

vertexclique opened a new pull request #7734:
URL: https://github.com/apache/arrow/pull/7734


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7734:
URL: https://github.com/apache/arrow/pull/7734#issuecomment-657714889


   https://issues.apache.org/jira/browse/ARROW-8480


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bluss edited a comment on pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

Posted by GitBox <gi...@apache.org>.
bluss edited a comment on pull request #7734:
URL: https://github.com/apache/arrow/pull/7734#issuecomment-736685727


   It is claimed https://issues.apache.org/jira/browse/ARROW-8480 is solved by this PR, but this PR does not add checks for allocation faliure, and there are still bugs to spot in the code due to that unfortunately. Examples: https://github.com/rust-ndarray/ndarray/issues/771#issuecomment-736684484


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bluss edited a comment on pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

Posted by GitBox <gi...@apache.org>.
bluss edited a comment on pull request #7734:
URL: https://github.com/apache/arrow/pull/7734#issuecomment-736685727


   It is claimed https://issues.apache.org/jira/browse/ARROW-8480 is solved by this PR, but this PR does not add checks for allocation faliure, and there are still bugs due to that, to spot in the code, unfortunately. Examples: https://github.com/rust-ndarray/ndarray/issues/771#issuecomment-736684484


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] wesm closed pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7734:
URL: https://github.com/apache/arrow/pull/7734


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bluss commented on pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

Posted by GitBox <gi...@apache.org>.
bluss commented on pull request #7734:
URL: https://github.com/apache/arrow/pull/7734#issuecomment-736685727


   It is claimed https://issues.apache.org/jira/browse/ARROW-8480 is solved by this PR, but this PR does not add checks for allocation faliure, and there are still bugs due to that, to spot in the code, unfortunately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org