You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2024/05/29 22:11:13 UTC
[PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
amoeba opened a new pull request, #41883:
URL: https://github.com/apache/arrow/pull/41883
### What changes are included in this PR?
- Updated azure.linux.yml task to remove what looks like an unneeded step
- Updated macros.ninja to replace use of CondaEnvironment@1 with an equivalent Bash@3 task
### Are these changes tested?
Testing in CI.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2164170166
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 17d0685cc3b171b6cd7e6e610a3eca766f4f0327.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/26158553566) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2162061956
Merged, thank you as always @kou.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2138344293
:warning: GitHub issue #41791 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #41883:
URL: https://github.com/apache/arrow/pull/41883#discussion_r1619543067
##########
dev/tasks/macros.jinja:
##########
@@ -220,15 +220,13 @@ env:
{%- macro azure_upload_anaconda(pattern) -%}
{%- if arrow.is_default_branch() -%}
- - task: CondaEnvironment@1
+ - task: Bash@3
inputs:
- packageSpecs: 'anaconda-client'
- installOptions: '-c conda-forge'
- updateConda: no
- - script: |
- conda install -y anaconda-client
- anaconda -t $(CROSSBOW_ANACONDA_TOKEN) upload --force {{ pattern }}
- displayName: Upload packages to Anaconda
+ targetType: inline
+ script: |
+ conda create -y -n azure_upload_anaconda -c conda-forge anaconda-client
Review Comment:
Could probably just install into the base environment to save time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2161649525
I tested a similar set of commands in a new Azure pipeline and found a couple of issues. https://github.com/apache/arrow/pull/41883/commits/b307165aedc16e3b2f2c775aa6f89a1b51694806 includes those fixes so I think this will run correct now. @kou do you want to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2138351228
@github-actions crossbow submit -g conda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41883:
URL: https://github.com/apache/arrow/pull/41883#discussion_r1635643938
##########
dev/tasks/macros.jinja:
##########
@@ -220,15 +220,10 @@ env:
{%- macro azure_upload_anaconda(pattern) -%}
{%- if arrow.is_default_branch() -%}
- - task: CondaEnvironment@1
- inputs:
- packageSpecs: 'anaconda-client'
- installOptions: '-c conda-forge'
- updateConda: no
- - script: |
- conda install -y anaconda-client
- anaconda -t $(CROSSBOW_ANACONDA_TOKEN) upload --force {{ pattern }}
- displayName: Upload packages to Anaconda
+ - bash: |
+ conda create -y -n azure_upload_anaconda -c conda-forge anaconda-client
+ source activate azure_upload_anaconda
+ anaconda -t $(CROSSBOW_ANACONDA_TOKEN) upload --force {{ pattern }}
Review Comment:
Could you unindent them?
```suggestion
conda create -y -n azure_upload_anaconda -c conda-forge anaconda-client
source activate azure_upload_anaconda
anaconda -t $(CROSSBOW_ANACONDA_TOKEN) upload --force {{ pattern }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2138353566
Revision: 8499e6701afbf02c039ff6ac88f73934bc7b6da6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d8f8170455](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d8f8170455)
|Task|Status|
|----|------|
|conda-clean|[](https://github.com/ursacomputing/crossbow/runs/25577915188)|
|conda-linux-aarch64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915397)|
|conda-linux-aarch64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915477)|
|conda-linux-ppc64le-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915220)|
|conda-linux-ppc64le-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/25577914878)|
|conda-linux-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915411)|
|conda-linux-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915201)|
|conda-osx-arm64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915345)|
|conda-osx-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915436)|
|conda-win-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915224)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/25577915141)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba merged PR #41883:
URL: https://github.com/apache/arrow/pull/41883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2138360222
Hrm. Is there actually a good way to test this? The bit I updated is guarded by an `arrow.is_default_branch()` but I also don't want to mess anything up on Anaconda.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2161550944
Before merging, I wanted to make sure my change actually works. I think I can just create a test pipeline on Azure to make sure my change does what I think it will do. I'll report back once that runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41791: [CI][Conda] Update azure.linux.yml task, replace CondaEnvironment@1 with Bash@3 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41883:
URL: https://github.com/apache/arrow/pull/41883#issuecomment-2156311515
What is the blocker of this?
It seems that we can start building with Docker but it's failed. (I think that it's out-of-scope of this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org