You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/10 15:50:50 UTC

[GitHub] [rocketmq-dashboard] StyleTang opened a new pull request #51: [ISSUE #48] Fix Normal User login after to tips:no permission

StyleTang opened a new pull request #51:
URL: https://github.com/apache/rocketmq-dashboard/pull/51


   ## What is the purpose of the change
   
   Update `role-permission.yml` default value to make RocketMQ-Dashboard easier to use.
   
   ## Brief changelog
   
   Update `role-permission.yml` default value so that normal users can have read permission by default.
   
   ## Verifying this change
   
   local test succeed, normal user can access all read URI.
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #51: [ISSUE #48] Fix Normal User login after to tips:no permission

Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #51:
URL: https://github.com/apache/rocketmq-dashboard/pull/51#discussion_r767751868



##########
File path: src/main/java/org/apache/rocketmq/dashboard/controller/DlqMessageController.java
##########
@@ -83,7 +83,7 @@ public Object batchResendDlqMessage(@RequestBody List<DlqMessageRequest> dlqMess
         return dlqMessageService.batchResendDlqMessage(dlqMessages);
     }
 
-    @PostMapping(value = "/batchExportDlqMessage.do")

Review comment:
       > The query suffix is not appropriate for interfaces of the operation type.
   
   Offline synced, there will be another PR to refactor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq-dashboard] zhangjidi2016 commented on a change in pull request #51: [ISSUE #48] Fix Normal User login after to tips:no permission

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on a change in pull request #51:
URL: https://github.com/apache/rocketmq-dashboard/pull/51#discussion_r767237558



##########
File path: src/main/java/org/apache/rocketmq/dashboard/controller/DlqMessageController.java
##########
@@ -83,7 +83,7 @@ public Object batchResendDlqMessage(@RequestBody List<DlqMessageRequest> dlqMess
         return dlqMessageService.batchResendDlqMessage(dlqMessages);
     }
 
-    @PostMapping(value = "/batchExportDlqMessage.do")

Review comment:
       The query suffix is not appropriate for interfaces of the operation type.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq-dashboard] vongosling commented on a change in pull request #51: [ISSUE #48] Fix Normal User login after to tips:no permission

Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #51:
URL: https://github.com/apache/rocketmq-dashboard/pull/51#discussion_r767356626



##########
File path: src/main/java/org/apache/rocketmq/dashboard/controller/DlqMessageController.java
##########
@@ -83,7 +83,7 @@ public Object batchResendDlqMessage(@RequestBody List<DlqMessageRequest> dlqMess
         return dlqMessageService.batchResendDlqMessage(dlqMessages);
     }
 
-    @PostMapping(value = "/batchExportDlqMessage.do")

Review comment:
       exportDlqMessage.query, there are 2 verbs in this interface :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq-dashboard] StyleTang merged pull request #51: [ISSUE #48] Fix Normal User login after to tips:no permission

Posted by GitBox <gi...@apache.org>.
StyleTang merged pull request #51:
URL: https://github.com/apache/rocketmq-dashboard/pull/51


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org