You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Tajdar Siddiqui (JIRA)" <ji...@apache.org> on 2016/09/26 13:44:20 UTC
[jira] [Commented] (KYLIN-2042) QueryController puts entry in Cache
w/o checking QueryCacheEnabled
[ https://issues.apache.org/jira/browse/KYLIN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523100#comment-15523100 ]
Tajdar Siddiqui commented on KYLIN-2042:
----------------------------------------
Created the following gist :
https://gist.github.com/tajdars/5c5a1df6195af9135e23c3f1269175c3
Can someone pls. review.
Thanx,
> QueryController puts entry in Cache w/o checking QueryCacheEnabled
> ------------------------------------------------------------------
>
> Key: KYLIN-2042
> URL: https://issues.apache.org/jira/browse/KYLIN-2042
> Project: Kylin
> Issue Type: Improvement
> Components: REST Service
> Reporter: Tajdar Siddiqui
> Assignee: Zhong,Jason
>
> org.apache.kylin.rest.controller.QueryController
> around line 168
> private SQLResponse doQueryWithCache(SQLRequest sqlRequest)
> cacheManager.getCache(SUCCESS_QUERY_CACHE).put(new Element(sqlRequest, sqlResponse));
> This should be conditional on KylinConfig.getInstanceFromEnv().isQueryCacheEnabled() as well ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)