[jira] [Commented] (FLINK-2459) Failure on recently added Client side logging test

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650417#comment-14650417 ] 

Stephan Ewen commented on FLINK-2459:
-------------------------------------

How about reworking the test as a whole? Right now, it starts an entire cluster, just to validate that a flag is passed from the command line interface to the Client class. This can be tested in a Unit test style, by just instantiating the CLI with a mock client and validating that the flag is properly passed.

The problem is that we cannot add these "start a cluster" tests for every configuration flag. Starting a local cluster takes a bit (Akka initialization is fairly slow) and the sum of these tests already blows up the build times.

> Failure on recently added Client side logging test
> --------------------------------------------------
>
>                 Key: FLINK-2459
>                 URL: https://issues.apache.org/jira/browse/FLINK-2459
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> A recent commit (authored by me) added a flag on CliFrontend to disable sysout logging on console. The unit test for this fails sporadically because of unavailable port while starting the cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)