You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/04 14:25:43 UTC
[GitHub] [tvm] alicja-SiMa-ai opened a new pull request #9443: Fix group transpose conv2d
alicja-SiMa-ai opened a new pull request #9443:
URL: https://github.com/apache/tvm/pull/9443
Shape of weights was incorrectly set for grouped transposed conv2D and implementation of the grouped transposed conv2D was missing. As a result, some models were not supported. Please see example of the CenterNet model [here](https://discuss.tvm.apache.org/t/centernet-dlav0-pytorch-to-tvm-is-wrong-who-can-help-me/6532) with error message`in particular dimension 1 conflicts 0 does not match 1; unable to unify: Tensor[(256, 0, 4, 4), float32] and Tensor[(256, 1, 4, 4), float32]`.
This PR adds missing implementation and required tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9443:
URL: https://github.com/apache/tvm/pull/9443#issuecomment-967334251
Thank you @alicja-SiMa-ai for the huge effort!! This is super helpful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alicja-SiMa-ai commented on pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
alicja-SiMa-ai commented on pull request #9443:
URL: https://github.com/apache/tvm/pull/9443#issuecomment-962037239
@AndrewZhaoLuo #9336 changes the layout conversion. This PR addresses a different issue, it adds implementation of group transpose convolution 2D which was missing and fixes weight shape to support groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9443:
URL: https://github.com/apache/tvm/pull/9443#issuecomment-967290911
@Lyken17 @alicja-SiMa-ai just to double check, is this commit superseded via this commit https://github.com/apache/tvm/commit/3ad7c4a76933dbb47d794f75be7ad4d0c52e1e10? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #9443:
URL: https://github.com/apache/tvm/pull/9443#issuecomment-961625362
Hmm is this perhaps related to #9336 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alicja-SiMa-ai commented on pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
alicja-SiMa-ai commented on pull request #9443:
URL: https://github.com/apache/tvm/pull/9443#issuecomment-967329128
Yes @junrushao1994, it was integrated into #9465. Closing this one. Thanks everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alicja-SiMa-ai closed pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
alicja-SiMa-ai closed pull request #9443:
URL: https://github.com/apache/tvm/pull/9443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #9443:
URL: https://github.com/apache/tvm/pull/9443#issuecomment-961625362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alicja-SiMa-ai commented on pull request #9443: Fix group transpose conv2d
Posted by GitBox <gi...@apache.org>.
alicja-SiMa-ai commented on pull request #9443:
URL: https://github.com/apache/tvm/pull/9443#issuecomment-962037239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org