You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/30 13:54:46 UTC
[GitHub] [skywalking-kubernetes-event-exporter] kezhenxu94 opened a new pull request #1: chore: set up CI workflow
kezhenxu94 opened a new pull request #1:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes-event-exporter] kezhenxu94 merged pull request #1: chore: set up CI workflow
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #1:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes-event-exporter] wu-sheng commented on a change in pull request #1: chore: set up CI workflow
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/1#discussion_r605371791
##########
File path: pkg/exporter/skywalking.go
##########
@@ -89,7 +91,7 @@ func (exporter *SkyWalking) Export(events chan *k8score.Event) {
case <-exporter.stopper:
logger.Log.Debugf("draining event channel")
for e := range events {
- if e == event.Stopper {
+ if e == evnt.Stopper {
Review comment:
Mischange?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes-event-exporter] kezhenxu94 commented on a change in pull request #1: chore: set up CI workflow
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-kubernetes-event-exporter/pull/1#discussion_r605375760
##########
File path: pkg/exporter/skywalking.go
##########
@@ -89,7 +91,7 @@ func (exporter *SkyWalking) Export(events chan *k8score.Event) {
case <-exporter.stopper:
logger.Log.Debugf("draining event channel")
for e := range events {
- if e == event.Stopper {
+ if e == evnt.Stopper {
Review comment:
It was package alias, now fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org