[GitHub] jzgithub1 commented on a change in pull request #926: Move AccumuloClient.getInstanceID to InstanceOperations

[GitBox <gi...@apache.org>]

jzgithub1 commented on a change in pull request #926: Move AccumuloClient.getInstanceID to InstanceOperations
URL: https://github.com/apache/accumulo/pull/926#discussion_r253912569
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java
 ##########
 @@ -232,4 +232,10 @@ public static String lookupInstanceName(ZooCache zooCache, UUID instanceId) {
     }
     return null;
   }
+
+  @Override
+  public String getInstanceID() {
 
 Review comment:
   Removing getInstance from AccumuloClient breaks the mock object call to getInstance in the UnorderedWorkAssignerTest in the workNotInZooKeeperIsCleanedUp() test.  I will probably see this in the ServerContext mock objects too but have not got there yet.  I will look for some workaround.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services