You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/04 15:39:04 UTC

[GitHub] [airflow] galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively

galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively
URL: https://github.com/apache/airflow/pull/4743#issuecomment-479949735
 
 
   Hi everyone
   
   I do not want to be rude. I'm sure everyone has a lot to do, especially on this awesome product which is Airflow! But some constructive feedback on this PR (as well on the related issue) would be tremendously appreciated... 
   
   _About the need:_ Supporting nested template fields rendering in Operators would be really helpful to better design our DAGs. And it could also probably help other users. Of course, the Airflow team might have some good reason to decide this feature won't be supported. In such a case, we could first have a discussion about the need, and then have a clear explanation why this feature could not be supported. 
   
   _About the PR:_ IMHO, the solution reached with @bjoernpollex-sc 's help is solving most of the use cases. Of course, there might be a better solution. Any thoughts or suggestions to improve this PR would be welcome, and I would be glad to rework it if we can find a consensus.
   
   My intent is to help improving Airflow. I'm glad this tool exists and I'm glad I can use it.
   Keep up the good work guys!
   Thank you
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services