[GitHub] [maven-fluido-skin] slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration
URL: https://github.com/apache/maven-fluido-skin/pull/15#discussion_r397476454
 
 

 ##########
 File path: src/main/resources/META-INF/maven/site-macros.vm
 ##########
 @@ -678,11 +682,11 @@ $indent     </ul>##
 #*  *##if ( $sideBarEnabled )
 #*    *##set( $dataSize = "medium" )
 #*    *##set( $dataAlign = "left" )
-    <div id="twitter">
+    <div id="twitter" style="border:none; margin-top: 10px">
 #*  *##else
 #*    *##set( $dataSize = "large" )
 #*    *##set( $dataAlign = "right" )
-    <ul class="nav pull-right"><li>
+    <ul class="nav pull-right" style="border:none; margin-top: 7px"><li>
 
 Review comment:
   Because Twitter button was start from top without margin. 
   Google search and facebook has some margin from top.
   It didn't look good.
   You can see original. eg: https://maven.apache.org/skins/maven-fluido-skin/mskins-24_topbar/index.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services