[GitHub] xtinec commented on a change in pull request #6667: [SIP6][WIP] Remove backend logic of tablevis.

[GitBox <gi...@apache.org>]

xtinec commented on a change in pull request #6667: [SIP6][WIP] Remove backend logic of tablevis.
URL: https://github.com/apache/incubator-superset/pull/6667#discussion_r248065591
 
 

 ##########
 File path: superset/assets/src/explore/exploreUtils.js
 ##########
 @@ -45,8 +45,10 @@ export function getURIDirectory({
     directory = '/superset/explore_json/';
   }
   // const buildQueryRegistry = getChartBuildQueryRegistry();
-  if (formData.viz_type === 'word_cloud' && !forceExplore) {
-    directory = '/api/v1/query/';
+  if (formData.viz_type === 'word_cloud' ||
+        formData.viz_type === 'table' &&
 
 Review comment:
   Perhaps worthwhile defining an array of `viz_type`s to "whitelist" for the query endpoint and checking that the `viz_type` from `form_data` is in that array (since we'll be adding new ones soon)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org