You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/26 13:03:26 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in
HyukjinKwon opened a new pull request, #37297:
URL: https://github.com/apache/spark/pull/37297
### What changes were proposed in this pull request?
This PR is similar with https://github.com/apache/spark/pull/37291. Call `System.gc()`.
### Why are the changes needed?
To deflake it. See https://github.com/MaxGekk/spark/runs/7516270590?check_suite_focus=true
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
Should monitor CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in BroadcastJoinSuite*
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in BroadcastJoinSuite*
URL: https://github.com/apache/spark/pull/37297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in BroadcastJoinSuite*
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37297:
URL: https://github.com/apache/spark/pull/37297#issuecomment-1195458719
`local-cluster[2,1,1024]` is used in many places, should we reduce memory usage on the premise that we can pass the suites, such as using `local-cluster[2,1,768]` or `local-cluster[2,1,512]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in BroadcastJoinSuite*
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37297:
URL: https://github.com/apache/spark/pull/37297#issuecomment-1195475673
Let's try what you suggested if the flakiness persists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37297:
URL: https://github.com/apache/spark/pull/37297#issuecomment-1195456087
This will likely the last place given my look at the flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in BroadcastJoinSuite*
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37297:
URL: https://github.com/apache/spark/pull/37297#issuecomment-1195476022
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in BroadcastJoinSuite*
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37297:
URL: https://github.com/apache/spark/pull/37297#issuecomment-1195475250
That's one idea. Let me get this in first though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37297: [SPARK-39874][SQL][TESTS] Add System.gc at beforeEach in BroadcastJoinSuite*
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37297:
URL: https://github.com/apache/spark/pull/37297#issuecomment-1195570706
I give a pr for GA test and will close it if no longer needed
https://github.com/apache/spark/pull/37298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org