Re: [PR] [python] Support FileStoreCommit overwrite dynamic partition [paimon]

["XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>]

XiaoHongbo-Hope commented on code in PR #7749:
URL: https://github.com/apache/paimon/pull/7749#discussion_r3171988423


##########
paimon-python/pypaimon/write/file_store_commit.py:
##########
@@ -518,6 +514,34 @@ def _is_duplicate_commit(self, retry_result, latest_snapshot, commit_identifier,
                     return True
         return False
 
+    def _create_dynamic_partition_filter(self, commit_messages: List[CommitMessage]):
+        """Build a partition filter from the unique partitions present in commit_messages."""
+        predicate_builder = PredicateBuilder(self.table.partition_keys_fields)
+        predicates = []
+        seen_partitions = set()
+        for msg in commit_messages:
+            partition_values = tuple(msg.partition)
+            if partition_values not in seen_partitions:
+                seen_partitions.add(partition_values)
+                equalities = [predicate_builder.equal(name, value)

Review Comment:
   It seems that this does not handle NULL partition values correctly, could you add a case for null partition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org