You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Abda11ah255 (via GitHub)" <gi...@apache.org> on 2026/10/11 03:07:57 UTC

[PR] chore: rename command data classes for CQRS [fineract-consumer-facing]

Abda11ah255 opened a new pull request, #197:
URL: https://github.com/apache/fineract-consumer-facing/pull/197

   Fixes #187


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: rename command data classes for CQRS [fineract-consumer-facing]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal closed pull request #197: chore: rename command data classes for CQRS
URL: https://github.com/apache/fineract-consumer-facing/pull/197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: rename command data classes for CQRS [fineract-consumer-facing]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #197:
URL: https://github.com/apache/fineract-consumer-facing/pull/197#issuecomment-6104885526

   <!-- signed-commits -->
   
   ## Commits on this pull request are not verified
   
   1 of 1 commit is not showing as **Verified** on GitHub, so this pull request cannot be merged into `main` yet.
   
   ### `unsigned`
   
   These commits carry no signature at all.
   
   - `d40141f2` chore: rename command data classes for CQRS
   
   **How to fix:** Set up commit signing, then re-sign the commits already on this branch. [CONTRIBUTING.md](https://github.com/apache/fineract-consumer-facing/blob/main/CONTRIBUTING.md#signing-your-commits) has the setup.
   
   ### Re-signing
   
   ```bash
   # only for the identity reasons above (no_user / unverified_email):
   git config user.email "you@example.com"
   
   # re-sign every commit on this branch:
   git rebase --exec 'git commit --amend --no-edit --reset-author -S' origin/main
   git push --force-with-lease
   ```
   
   Force-pushing is expected here: re-signing rewrites the commits, so their hashes change.
   
   ---
   
   This comment is posted automatically and updates itself when you push; it disappears once every commit verifies. If you believe this is wrong, say so on the pull request; a maintainer can check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: rename command data classes for CQRS [fineract-consumer-facing]

Posted by "Abda11ah255 (via GitHub)" <gi...@apache.org>.
Abda11ah255 commented on PR #197:
URL: https://github.com/apache/fineract-consumer-facing/pull/197#issuecomment-6116906072

   I have updated the class names in the test files as requested.but I couldnt pass the ConsumerApiClientFactory(the missing package) test as they couldn't get generated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: rename command data classes for CQRS [fineract-consumer-facing]

Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on PR #197:
URL: https://github.com/apache/fineract-consumer-facing/pull/197#issuecomment-6114025161

   hi @Abda11ah255, please update test files as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore: rename command data classes for CQRS [fineract-consumer-facing]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on PR #197:
URL: https://github.com/apache/fineract-consumer-facing/pull/197#issuecomment-6434658348

   Closing this due to inactivity


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org