You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/28 22:14:52 UTC
[PR] chore(infra): collect local-dev tooling under bin/local-dev/ [texera]
Yicong-Huang opened a new pull request, #5994:
URL: https://github.com/apache/texera/pull/5994
### What changes were proposed in this PR?
`bin/local-dev/` already housed the docker-compose overlay + the two test suites, but the engine files that drive everything sat one level up next to a dozen unrelated `bin/*.sh`. Move them in:
```
bin/local-dev.sh → bin/local-dev/main.sh (engine)
bin/local-dev-tui.py → bin/local-dev/tui.py (Textual dashboard)
```
A 3-line wrapper stays at `bin/local-dev.sh`, so muscle memory + every `bin/local-dev.sh ...` invocation (docs, contributor habit, scripts) keeps working unchanged. The wrapper is the **only** path users ever see — `--help`, error hints, status-screen tip block, and the new `bin/local-dev/README.md` all reference `bin/local-dev.sh`; the engine path isn't surfaced anywhere a user runs into.
After:
```
bin/
├── local-dev.sh ← thin wrapper: exec local-dev/main.sh "$@"
└── local-dev/
├── main.sh ← engine (was bin/local-dev.sh)
├── tui.py ← Textual TUI (was bin/local-dev-tui.py)
├── docker-compose.override.yml
├── README.md ← new (folder layout + how to run tests + how to add a service)
└── tests/
```
Path updates that follow from the move:
* `main.sh`: `REPO_ROOT` climbs `../..` instead of `..`; TUI exec path points at `bin/local-dev/tui.py`.
* `tui.py`: `REPO_ROOT = Path(__file__).resolve().parents[2]`.
* `tests/conftest.py`: `TUI_PATH` updated.
* `tests/test_local_dev_sh.sh`: the `bash -n` check discovers every `*.sh` under `bin/local-dev/` via `find -print0` (macOS bash 3.2 has no `globstar`), so the wrapper's syntax check now covers the engine too.
`bin/**`-anchored labeler + CI globs (`infra:` label, `find bin -name 'test_*.sh'`, `pytest bin/`) keep matching without edit.
### Any related issues, documentation, discussions?
Closes #5993.
### How was this PR tested?
* `bash bin/local-dev/tests/test_local_dev_sh.sh` → `9 passed, 0 failed`.
* `python -m pytest bin/local-dev/tests/ -q` → `38 passed in 0.13s`.
* `bin/local-dev.sh version` returns the expected `1.3.0-incubating-SNAPSHOT`.
* `bin/local-dev.sh --help` and `bin/local-dev.sh status` (no-arg) render the same dashboard + tip block as before, all referencing `bin/local-dev.sh` (no `main.sh` leakage).
* `bin/local-dev.sh -i` was sanity-checked manually: the TUI loads and the dashboard binds to the same state directory.
Both test suites also run in the `infra` GitHub Actions job; no workflow changes are needed.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Anthropic, Claude Opus 4.7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(infra): collect local-dev tooling under bin/local-dev/ [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5994:
URL: https://github.com/apache/texera/pull/5994#issuecomment-4827561679
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(infra): collect local-dev tooling under bin/local-dev/ [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 merged PR #5994:
URL: https://github.com/apache/texera/pull/5994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(infra): collect local-dev tooling under bin/local-dev/ [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5994:
URL: https://github.com/apache/texera/pull/5994#issuecomment-4827593187
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 4 better · 🔴 4 worse · ⚪ 7 noise (<±5%) · 0 without baseline
> Compared against main `1689167` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28337979924)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 371 | 0.226 | 26,193/35,937/35,937 us | 🔴 +20.9% / 🔴 +134.4% |
| 🔴 | bs=100 sw=10 sl=64 | 808 | 0.493 | 125,276/135,238/135,238 us | 🟢 -8.8% / 🔴 +22.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 907 | 0.553 | 1,102,590/1,141,541/1,141,541 us | ⚪ within ±5% / 🔴 +7.6% |
<details><summary>Baseline details</summary>
Latest main `1689167` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 371 tuples/sec | 412 tuples/sec | 757.16 tuples/sec | -10.0% | -51.0% |
| bs=10 sw=10 sl=64 | MB/s | 0.226 MB/s | 0.252 MB/s | 0.462 MB/s | -10.3% | -51.1% |
| bs=10 sw=10 sl=64 | p50 | 26,193 us | 21,664 us | 12,971 us | +20.9% | +101.9% |
| bs=10 sw=10 sl=64 | p95 | 35,937 us | 38,339 us | 15,333 us | -6.3% | +134.4% |
| bs=10 sw=10 sl=64 | p99 | 35,937 us | 38,339 us | 18,732 us | -6.3% | +91.8% |
| bs=100 sw=10 sl=64 | throughput | 808 tuples/sec | 838 tuples/sec | 957.66 tuples/sec | -3.6% | -15.6% |
| bs=100 sw=10 sl=64 | MB/s | 0.493 MB/s | 0.511 MB/s | 0.585 MB/s | -3.5% | -15.7% |
| bs=100 sw=10 sl=64 | p50 | 125,276 us | 115,284 us | 103,982 us | +8.7% | +20.5% |
| bs=100 sw=10 sl=64 | p95 | 135,238 us | 148,242 us | 110,583 us | -8.8% | +22.3% |
| bs=100 sw=10 sl=64 | p99 | 135,238 us | 148,242 us | 118,369 us | -8.8% | +14.3% |
| bs=1000 sw=10 sl=64 | throughput | 907 tuples/sec | 913 tuples/sec | 979.6 tuples/sec | -0.7% | -7.4% |
| bs=1000 sw=10 sl=64 | MB/s | 0.553 MB/s | 0.557 MB/s | 0.598 MB/s | -0.7% | -7.5% |
| bs=1000 sw=10 sl=64 | p50 | 1,102,590 us | 1,097,530 us | 1,024,553 us | +0.5% | +7.6% |
| bs=1000 sw=10 sl=64 | p95 | 1,141,541 us | 1,133,616 us | 1,063,789 us | +0.7% | +7.3% |
| bs=1000 sw=10 sl=64 | p99 | 1,141,541 us | 1,133,616 us | 1,096,239 us | +0.7% | +4.1% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,538.99,200,128000,371,0.226,26192.76,35937.23,35937.23
1,100,10,64,20,2474.55,2000,1280000,808,0.493,125275.86,135238.38,135238.38
2,1000,10,64,20,22056.86,20000,12800000,907,0.553,1102589.94,1141541.35,1141541.35
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(infra): collect local-dev tooling under bin/local-dev/ [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5994:
URL: https://github.com/apache/texera/pull/5994#issuecomment-4827588446
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5994?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.26%. Comparing base ([`2f5faa1`](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f11c139`](https://app.codecov.io/gh/apache/texera/commit/f11c139fe7c9fcd32c3f8628def2e6d1f74248bb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5994 +/- ##
=========================================
Coverage 56.26% 56.26%
Complexity 2988 2988
=========================================
Files 1120 1120
Lines 43167 43167
Branches 4658 4658
=========================================
Hits 24287 24287
Misses 17458 17458
Partials 1422 1422
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.77% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.56% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.02% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | |
| [python](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [2f5faa1](https://app.codecov.io/gh/apache/texera/commit/2f5faa14a0ed89cce146a1dff8c15c76781fa985?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5994?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org