[GitHub] [pinot] deemoliu commented on a diff in pull request #10836: refactor ConcurrentMapPartitionUpsertMetadataManager constructor

["deemoliu (via GitHub)" <gi...@apache.org>]

deemoliu commented on code in PR #10836:
URL: https://github.com/apache/pinot/pull/10836#discussion_r1214911616


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java:
##########
@@ -55,24 +52,21 @@ public void init(TableConfig tableConfig, Schema schema, TableDataManager tableD
     Preconditions.checkArgument(!CollectionUtils.isEmpty(_primaryKeyColumns),
         "Primary key columns must be configured for upsert enabled table: %s", _tableNameWithType);
 
-    _comparisonColumns = upsertConfig.getComparisonColumns();
-    if (_comparisonColumns == null) {
-      _comparisonColumns = Collections.singletonList(tableConfig.getValidationConfig().getTimeColumnName());
+    _upsertConfig = upsertConfig;
+    List<String> comparisonColumns = upsertConfig.getComparisonColumns();
+    if (comparisonColumns == null) {
+      comparisonColumns = Collections.singletonList(tableConfig.getValidationConfig().getTimeColumnName());

Review Comment:
   good catch. let me add this part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org