You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/07 07:40:33 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3726: NO-JIRA Adding quorum paging & large msg BackupSyncJournalTest
franz1981 opened a new pull request #3726:
URL: https://github.com/apache/activemq-artemis/pull/3726
@clebertsuconic This is just adding support to other 2 scenarios, but given that replication process is 1:1 with the `classic` replication I'm not sure yet if makes sense to have both tests in (pluggable quorum + classic); maybe I can get rid of the original one and replace with this?
I'm opened to suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic edited a comment on pull request #3726: NO-JIRA Adding quorum paging & large msg BackupSyncJournalTest
Posted by GitBox <gi...@apache.org>.
clebertsuconic edited a comment on pull request #3726:
URL: https://github.com/apache/activemq-artemis/pull/3726#issuecomment-914268813
@franz1981 we definitely don't need both.. that test was intended to test the sync process....
I would make sure we only run only one of them.. make the pluggable one.. and get rid of the other, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3726: NO-JIRA Adding quorum paging & large msg BackupSyncJournalTest
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3726:
URL: https://github.com/apache/activemq-artemis/pull/3726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3726: NO-JIRA Adding quorum paging & large msg BackupSyncJournalTest
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3726:
URL: https://github.com/apache/activemq-artemis/pull/3726#issuecomment-914268813
we definitely don't need both.. that test was intended to test the sync process....
I would make sure we only run only one of them.. make the pluggable one.. and get rid of the other, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3726: NO-JIRA Adding quorum paging & large msg BackupSyncJournalTest
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3726:
URL: https://github.com/apache/activemq-artemis/pull/3726#issuecomment-914276996
@franz1981 this LGTM... can you make it ready for review and merge it yourself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3726: NO-JIRA Adding quorum paging & large msg BackupSyncJournalTest
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3726:
URL: https://github.com/apache/activemq-artemis/pull/3726#issuecomment-914276654
@franz1981 actually.. I take that back.. I thought those were long running tests... (taking minutes to run)... and they take seconds...
I don't mind if we keep the extra tests on this case.. if they were taking a lot of time I would make a case for them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org