You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 14:40:36 UTC
[GitHub] [airflow] egibbm opened a new pull request #9349: [#9347] Fix QuboleHook unable to add list to tags
egibbm opened a new pull request #9349:
URL: https://github.com/apache/airflow/pull/9349
Upon upgrading to 1.10.10, existing behavior of accepting a list of tags in QuboleOperator() dag have broken due to a [refactor](https://github.com/apache/airflow/pull/5786). This fix should have the same behavior of handling tags as expected before the refactor.
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit merged pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
msumit merged pull request #9349:
URL: https://github.com/apache/airflow/pull/9349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chattarajoy commented on a change in pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
chattarajoy commented on a change in pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#discussion_r443417306
##########
File path: tests/test_project_structure.py
##########
@@ -44,7 +44,6 @@
'tests/providers/microsoft/azure/sensors/test_azure_cosmos.py',
'tests/providers/microsoft/mssql/hooks/test_mssql.py',
'tests/providers/oracle/operators/test_oracle.py',
- 'tests/providers/qubole/hooks/test_qubole.py',
Review comment:
Why is this removed? I see you've added the file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] egibbm commented on a change in pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
egibbm commented on a change in pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#discussion_r443474198
##########
File path: tests/test_project_structure.py
##########
@@ -43,7 +43,6 @@
'tests/providers/jenkins/hooks/test_jenkins.py',
'tests/providers/microsoft/azure/sensors/test_azure_cosmos.py',
'tests/providers/microsoft/mssql/hooks/test_mssql.py',
- 'tests/providers/qubole/hooks/test_qubole.py',
Review comment:
This is the reason why we remove the line:
https://github.com/apache/airflow/pull/9349/checks?check_run_id=781002396
I hope this clears up the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#issuecomment-648640311
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] egibbm commented on a change in pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
egibbm commented on a change in pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#discussion_r443470966
##########
File path: tests/test_project_structure.py
##########
@@ -43,7 +43,6 @@
'tests/providers/jenkins/hooks/test_jenkins.py',
'tests/providers/microsoft/azure/sensors/test_azure_cosmos.py',
'tests/providers/microsoft/mssql/hooks/test_mssql.py',
- 'tests/providers/qubole/hooks/test_qubole.py',
Review comment:
Because we have added the test_qubole.py by [this commit](https://github.com/apache/airflow/pull/9349/commits/d48ea0a167c4428c37fc2939779f11d03fef9863), and when the CI run I received a CI message to remove that line.
Pls cmiiw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#discussion_r443472316
##########
File path: tests/test_project_structure.py
##########
@@ -43,7 +43,6 @@
'tests/providers/jenkins/hooks/test_jenkins.py',
'tests/providers/microsoft/azure/sensors/test_azure_cosmos.py',
'tests/providers/microsoft/mssql/hooks/test_mssql.py',
- 'tests/providers/qubole/hooks/test_qubole.py',
Review comment:
This is a test that checks for missing test files. This file has been added to this change, so we need to update this list to represent the current state.
This test has been added to inform the user about the project rules as soon as possible. No reviewer needs to inform users that we need unit tests.
It also simplifies the work of project maintainer, because it provides easy insight into project defects, which allows engaging other contributors to these tasks. More info: https://github.com/apache/airflow/issues/8278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] egibbm commented on a change in pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
egibbm commented on a change in pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#discussion_r444604450
##########
File path: tests/test_project_structure.py
##########
@@ -43,7 +43,6 @@
'tests/providers/jenkins/hooks/test_jenkins.py',
'tests/providers/microsoft/azure/sensors/test_azure_cosmos.py',
'tests/providers/microsoft/mssql/hooks/test_mssql.py',
- 'tests/providers/qubole/hooks/test_qubole.py',
Review comment:
@msumit can I resolve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9349: [#9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#issuecomment-645416469
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on a change in pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
msumit commented on a change in pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#discussion_r443468608
##########
File path: tests/test_project_structure.py
##########
@@ -43,7 +43,6 @@
'tests/providers/jenkins/hooks/test_jenkins.py',
'tests/providers/microsoft/azure/sensors/test_azure_cosmos.py',
'tests/providers/microsoft/mssql/hooks/test_mssql.py',
- 'tests/providers/qubole/hooks/test_qubole.py',
Review comment:
why this file has been removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chattarajoy commented on pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
chattarajoy commented on pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#issuecomment-647346942
thanks for taking this up @egibbm . LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] egibbm commented on a change in pull request #9349: [AIRFLOW-9347] Fix QuboleHook unable to add list to tags
Posted by GitBox <gi...@apache.org>.
egibbm commented on a change in pull request #9349:
URL: https://github.com/apache/airflow/pull/9349#discussion_r443471571
##########
File path: tests/test_project_structure.py
##########
@@ -43,7 +43,6 @@
'tests/providers/jenkins/hooks/test_jenkins.py',
'tests/providers/microsoft/azure/sensors/test_azure_cosmos.py',
'tests/providers/microsoft/mssql/hooks/test_mssql.py',
- 'tests/providers/qubole/hooks/test_qubole.py',
Review comment:
let me check. There might be a problem when merging master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org