You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "xuyanana (via GitHub)" <gi...@apache.org> on 2025/07/28 08:08:20 UTC
[PR] Update KafkaPartitionSplitReader.java [seatunnel]
xuyanana opened a new pull request, #9630:
URL: https://github.com/apache/seatunnel/pull/9630
1. 已有逻辑enable.auto.commit和commitOnCheckpoint保持一致会覆盖配置文件配置好的enable.auto.commit
2. enable.auto.commit和commitOnCheckpoint 同时为true, 当worker节点重启时会导致数据丢失(如: 消息从kafka中消费但未写入目标,不应该提交向kafka提交偏移量但enable.auto.commit为true,当kafka客户端关闭时会自动提交偏移量 )
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
-->
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#discussion_r2240038037
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaPartitionSplitReader.java:
##########
@@ -374,9 +374,6 @@ private KafkaConsumer<byte[], byte[]> initConsumer(
props.setProperty(
ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
ByteArrayDeserializer.class.getName());
- props.setProperty(
- ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG,
- String.valueOf(kafkaSourceConfig.isCommitOnCheckpoint()));
Review Comment:
I think we can handle it in KafkaSourceConfig, forcibly overwrite ENABLE_AUTO_COMMIT_CONFIG to false when COMMIT_ON_CHECKPOINT is true, and give a prompt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#discussion_r2239998367
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaPartitionSplitReader.java:
##########
@@ -374,9 +374,6 @@ private KafkaConsumer<byte[], byte[]> initConsumer(
props.setProperty(
ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
ByteArrayDeserializer.class.getName());
- props.setProperty(
- ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG,
- String.valueOf(kafkaSourceConfig.isCommitOnCheckpoint()));
Review Comment:
It is expected that when isCommitOnCheckpoint is true, ENABLE_AUTO_COMMIT_CONFIG should be false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#issuecomment-3314992379
@xuyanana Do you have time to update this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#issuecomment-3765962336
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "xuyanana (via GitHub)" <gi...@apache.org>.
xuyanana commented on PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#issuecomment-3132674898
Sure, I'll work on adding a unit test for this fix and push it shortly.
---- Replied Message ----
| From | Jia ***@***.***> |
| Date | 07/29/2025 21:54 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [apache/seatunnel] Update KafkaPartitionSplitReader.java (PR #9630) |
Hisoka-X left a comment (apache/seatunnel#9630)
Thanks @xuyanana . Could you add a unit test for this fix?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #9630: Update KafkaPartitionSplitReader.java
URL: https://github.com/apache/seatunnel/pull/9630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "xuyanana (via GitHub)" <gi...@apache.org>.
xuyanana commented on code in PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#discussion_r2240391197
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaPartitionSplitReader.java:
##########
@@ -374,9 +374,6 @@ private KafkaConsumer<byte[], byte[]> initConsumer(
props.setProperty(
ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
ByteArrayDeserializer.class.getName());
- props.setProperty(
- ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG,
- String.valueOf(kafkaSourceConfig.isCommitOnCheckpoint()));
Review Comment:
This plan is good. I will modify it in the 'create KafkaProperties' method of KafkaSourceConfig and submit a new version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#issuecomment-3797488194
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#issuecomment-3132643453
Thanks @xuyanana . Could you add a unit test for this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update KafkaPartitionSplitReader.java [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #9630:
URL: https://github.com/apache/seatunnel/pull/9630#issuecomment-3132627365
cc @Carl-Zhou-CN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org