You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/07/28 19:48:00 UTC
[jira] [Commented] (SOLR-14686) Remove log "[coreName]" (logid)
which is redundant with MDC
[ https://issues.apache.org/jira/browse/SOLR-14686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166658#comment-17166658 ]
David Smiley commented on SOLR-14686:
-------------------------------------
Linking to SOLR-11745 as superceding because the PR here also adds a toString() that appends the core name to the default toString.
> Remove log "[coreName]" (logid) which is redundant with MDC
> -----------------------------------------------------------
>
> Key: SOLR-14686
> URL: https://issues.apache.org/jira/browse/SOLR-14686
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: logging
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
>
> SolrCore.logid is used mostly by some log statements within SolrCore to log the core name at the start of some (not all) log messages. It pre-dated MDC and I believe it's basically obsolete now, and contributes to needless logging verbosity. The info levels where this appears if for opening a new SolrCore, closing a SolrCore, registering a new searcher, and it's in the "requestLog" and thus will show up once for any HTTP request into a core (e.g. select, update, etc.). So removing this will disturb anyone parsing Solr's logs. Maybe this should wait till 9.0?
> There is _some_ value still because for cross-core join query, any pertinent log statements on the "fromIndex" would ideally be reported against that core and not the toIndex. That seems too minor to keep this old stuff around for though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org