You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/25 13:52:06 UTC

[GitHub] [incubator-nuttx] davids5 opened a new pull request #1898: stm32f7:serial Bug Fix: Ensure next buffer is processed

davids5 opened a new pull request #1898:
URL: https://github.com/apache/incubator-nuttx/pull/1898


   ## Summary
   
      When the Head to Tail relationship was H < T, then
      only the tail to end of buffer was sent.
   
      The fix is: In the txdma completion to do a second
      the DMA operation using nbuffer if the nlength is
      non zero.
   
   stm32f7:serial UART5 use actual size
   
      UART5 was using the CONFIG_UART5_TXBUFSIZE
      not the UART5_TXBUFSIZE_ADJUSTED.
      Since the buffer size was adjusted up, this
      has no dcache implications.
      If the UART5_TXBUFSIZE_ADJUSTED is larger
      then CONFIG_UART5_TXBUFSIZE it will present
      a larger usable buffer to the system's
      serial driver.
   
   
   ## Impact
   master has critical data loss with TX DMA, this PR fixes that. 
   
   ## Testing
   
   PX4FMUv5X - serial test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1898: stm32f7:serial Bug Fix: Ensure next buffer is processed

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1898:
URL: https://github.com/apache/incubator-nuttx/pull/1898#issuecomment-699031018


   @xiaoxiang781216 
   
   Can you have a look and merge this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1898: stm32f7:serial Bug Fix: Ensure next buffer is processed

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1898:
URL: https://github.com/apache/incubator-nuttx/pull/1898#issuecomment-699156762


   Thank you!  @Ouss4 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1898: stm32f7:serial Bug Fix: Ensure next buffer is processed

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1898:
URL: https://github.com/apache/incubator-nuttx/pull/1898#issuecomment-699156260


   @acassis or @Ouss4  - Would one of you please merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1898: stm32f7:serial Bug Fix: Ensure next buffer is processed

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1898:
URL: https://github.com/apache/incubator-nuttx/pull/1898


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org