[GitHub] [incubator-doris] imay commented on a change in pull request #3264: [config] Support to modify configs when BE is running without restarting

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3264: [config] Support to modify configs when BE is running without restarting
URL: https://github.com/apache/incubator-doris/pull/3264#discussion_r404122147
 
 

 ##########
 File path: be/src/common/configbase.cpp
 ##########
 @@ -28,91 +28,19 @@
 #include "common/config.h"
 #undef __IN_CONFIGBASE_CPP__
 
+#include "common/status.h"
+#include "gutil/strings/substitute.h"
+
 namespace doris {
 namespace config {
 
-std::list<Register::Field>* Register::_s_fieldlist = nullptr;
-std::map<std::string, std::string>* confmap = nullptr;
+std::map<std::string, Register::Field>* Register::_s_fieldlist = nullptr;
 
 Review comment:
   ```suggestion
   std::map<std::string, Register::Field>* Register::_s_field_map = nullptr;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org