You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "nsivarajan (via GitHub)" <gi...@apache.org> on 2024/09/15 06:51:21 UTC
[PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
nsivarajan opened a new pull request, #30284:
URL: https://github.com/apache/superset/pull/30284
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR follows up on https://github.com/apache/superset/pull/29912 and removes the deprecated GLOBAL_ASYNC_QUERIES_REDIS_CONFIG configuration in favor of the new GLOBAL_ASYNC_QUERIES_CACHE_BACKEND configuration. It is intended to be merged into version 5.0.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2351418821
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/30284?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `75.00000%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 65.20%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`720a02f`)](https://app.codecov.io/gh/apache/superset/commit/720a02f280307ac488adb92013762cae0c8c9e14?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 731 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/30284?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/async\_events/async\_query\_manager.py](https://app.codecov.io/gh/apache/superset/pull/30284?src=pr&el=tree&filepath=superset%2Fasync_events%2Fasync_query_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FzeW5jX3F1ZXJ5X21hbmFnZXIucHk=) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/30284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #30284 +/- ##
==========================================
+ Coverage 60.48% 65.20% +4.71%
==========================================
Files 1931 534 -1397
Lines 76236 38544 -37692
Branches 8568 0 -8568
==========================================
- Hits 46114 25131 -20983
+ Misses 28017 13413 -14604
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.94% <75.00%> (-0.23%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.44% <75.00%> (-0.37%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.20% <75.00%> (+1.71%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/30284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.51% <75.00%> (+2.88%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/30284?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2604839482
The E2E failure is unrelated to this PR and will be fixed by https://github.com/apache/superset/pull/31933.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2605330723
Close/reopen to restart CI after fixed flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "nsivarajan (via GitHub)" <gi...@apache.org>.
nsivarajan commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2594323645
Hi @villebro,
I've pushed the recent commits to the PR. Could you please assist with the review when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "nsivarajan (via GitHub)" <gi...@apache.org>.
nsivarajan commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2592091405
@villebro Sure - I'll update in two days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2590675936
@nsivarajan can you rebase this PR? The breaking change window for 5.0 is open, so we can now merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "nsivarajan (via GitHub)" <gi...@apache.org>.
nsivarajan commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2606239516
@villebro - Thanks again, finally all green! please help to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #30284:
URL: https://github.com/apache/superset/pull/30284#discussion_r1920468675
##########
superset/async_events/async_query_manager.py:
##########
@@ -87,11 +90,9 @@ def get_cache_backend(
if cache_type == "RedisSentinelCache":
return RedisSentinelCacheBackend.from_config(cache_config)
- # TODO: Deprecate hardcoded plain Redis code and expand cache backend options.
- # Maintain backward compatibility with 'GLOBAL_ASYNC_QUERIES_REDIS_CONFIG' until it is deprecated. # noqa: E501
- return redis.Redis(
- **config["GLOBAL_ASYNC_QUERIES_REDIS_CONFIG"], decode_responses=True
- )
+ # TODO: Expand cache backend options.
+ # Removed support for deprecated 'GLOBAL_ASYNC_QUERIES_REDIS_CONFIG' as it is no longer needed. # noqa: E501
Review Comment:
This line is redundant
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2605402661
@nsivarajan can you rebase the PR to see if the flaky test now passes? Closing/reopening didn't resolve the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro closed pull request #30284: chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG
URL: https://github.com/apache/superset/pull/30284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2606240431
Finally!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30284:
URL: https://github.com/apache/superset/pull/30284#issuecomment-2353371790
I think @villebro has the most context here, so I'll request his review, and re-start our flaky E2E test while I'm at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #30284:
URL: https://github.com/apache/superset/pull/30284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG [superset]
Posted by "nsivarajan (via GitHub)" <gi...@apache.org>.
nsivarajan commented on code in PR #30284:
URL: https://github.com/apache/superset/pull/30284#discussion_r1920966817
##########
superset/async_events/async_query_manager.py:
##########
@@ -87,11 +90,9 @@ def get_cache_backend(
if cache_type == "RedisSentinelCache":
return RedisSentinelCacheBackend.from_config(cache_config)
- # TODO: Deprecate hardcoded plain Redis code and expand cache backend options.
- # Maintain backward compatibility with 'GLOBAL_ASYNC_QUERIES_REDIS_CONFIG' until it is deprecated. # noqa: E501
- return redis.Redis(
- **config["GLOBAL_ASYNC_QUERIES_REDIS_CONFIG"], decode_responses=True
- )
+ # TODO: Expand cache backend options.
+ # Removed support for deprecated 'GLOBAL_ASYNC_QUERIES_REDIS_CONFIG' as it is no longer needed. # noqa: E501
Review Comment:
Thank you! I’ve included the changes in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org