You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "gortiz (via GitHub)" <gi...@apache.org> on 2023/04/10 17:49:14 UTC
[GitHub] [pinot] gortiz opened a new pull request, #10585: Index conf disabled
gortiz opened a new pull request, #10585:
URL: https://github.com/apache/pinot/pull/10585
This PR changes how IndexConfig are enabled/disabled. Instead of using `enabled`, we will use `disabled`.
We discussed about this change in https://github.com/apache/pinot/pull/10584.
This changes breaks compatibility. Specifically if someone used `enabled: false` to disable an index, this PR will ignore that configuration, as shown in the following table:
| when enabled was | prev this PR | after this PR | if we use disabled |
|---|---|---|---|
| not defined | sometimes disables the index | enables the index | enables the index |
| null | sometimes disables the index | enables the index | enables the index |
| true | enables the index | enables the index | enables the index |
| false | disables the index | disables the index | **enables the index** |
We assume that given that this new way to configure indexes was merged less than three weeks ago and no release was made, customer won't be actually using `enabled: false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jadami10 commented on pull request #10585: Index conf disabled
Posted by "jadami10 (via GitHub)" <gi...@apache.org>.
jadami10 commented on PR #10585:
URL: https://github.com/apache/pinot/pull/10585#issuecomment-1502159355
I'll let jackie review/approve.
I can offer 1 data point since I initially raised the issue; I'm ok with the behavior switch. The only reason we have `"enabled": false` at the moment is from the initial bug and not because it was desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10585: Index conf disabled
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10585:
URL: https://github.com/apache/pinot/pull/10585#issuecomment-1502185581
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10585](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83d77bf) into [master](https://codecov.io/gh/apache/pinot/commit/440a938106a9c97a1e56ccc975ac009c8c705eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (440a938) will **decrease** coverage by `0.02%`.
> The diff coverage is `94.44%`.
```diff
@@ Coverage Diff @@
## master #10585 +/- ##
============================================
- Coverage 70.38% 70.36% -0.02%
- Complexity 5616 6481 +865
============================================
Files 2106 2106
Lines 112890 112891 +1
Branches 17001 17000 -1
============================================
- Hits 79456 79435 -21
- Misses 27872 27888 +16
- Partials 5562 5568 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.49% <0.00%> (+0.02%)` | :arrow_up: |
| integration2 | `24.09% <0.00%> (+<0.01%)` | :arrow_up: |
| unittests1 | `67.90% <94.44%> (-0.02%)` | :arrow_down: |
| unittests2 | `13.89% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pinot/segment/spi/index/creator/H3IndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L2NyZWF0b3IvSDNJbmRleENvbmZpZy5qYXZh) | `70.58% <75.00%> (ø)` | |
| [...pinot/segment/spi/index/DictionaryIndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L0RpY3Rpb25hcnlJbmRleENvbmZpZy5qYXZh) | `68.18% <83.33%> (ø)` | |
| [...he/pinot/segment/spi/index/ForwardIndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L0ZvcndhcmRJbmRleENvbmZpZy5qYXZh) | `62.00% <100.00%> (ø)` | |
| [...apache/pinot/segment/spi/index/FstIndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L0ZzdEluZGV4Q29uZmlnLmphdmE=) | `66.66% <100.00%> (ø)` | |
| [...ache/pinot/segment/spi/index/RangeIndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L1JhbmdlSW5kZXhDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...pache/pinot/segment/spi/index/TextIndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L1RleHRJbmRleENvbmZpZy5qYXZh) | `83.78% <100.00%> (ø)` | |
| [...ache/pinot/spi/config/table/BloomFilterConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL0Jsb29tRmlsdGVyQ29uZmlnLmphdmE=) | `68.00% <100.00%> (ø)` | |
| [...org/apache/pinot/spi/config/table/IndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL0luZGV4Q29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...apache/pinot/spi/config/table/JsonIndexConfig.java](https://codecov.io/gh/apache/pinot/pull/10585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL0pzb25JbmRleENvbmZpZy5qYXZh) | `91.89% <100.00%> (ø)` | |
... and [24 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10585/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10585: Index conf disabled
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10585:
URL: https://github.com/apache/pinot/pull/10585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org