You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/06 16:54:12 UTC

[GitHub] [hbase] bitoffdev commented on a change in pull request #2207: HBASE-24826 Add some comments for processlist in hbase shell

bitoffdev commented on a change in pull request #2207:
URL: https://github.com/apache/hbase/pull/2207#discussion_r466550578



##########
File path: hbase-shell/src/main/ruby/shell/commands/processlist.rb
##########
@@ -27,10 +27,10 @@ def help
 
   hbase> processlist
   hbase> processlist 'all'
-  hbase> processlist 'general'
-  hbase> processlist 'handler'
-  hbase> processlist 'rpc'
-  hbase> processlist 'operation'
+  hbase> processlist 'general'     //non-RPC Tasks, such as compact, flush etc

Review comment:
       Thanks for this @bsglz! Documentation like this is a little inconsistent in format throughout our commands, but I think it would be good to follow the precedent of the RSGroup commands and place these comments on the preceding lines with a ruby-style comment (`#`) since the shell is ruby.
   
   Ex: https://github.com/apache/hbase/blob/8003a15835690de6d36a91cef3d51eea3ba60129/hbase-shell/src/main/ruby/shell/commands/set_peer_tableCFs.rb#L35




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org