You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/02 14:19:29 UTC

[GitHub] [incubator-devlake] klesh opened a new pull request, #2660: fix: patch /blueprints/:id wouldn't handle byte[]

klesh opened a new pull request, #2660:
URL: https://github.com/apache/incubator-devlake/pull/2660

   # Summary
   
   `PATCH /blueprints/:id` was using `mapstructure.Decode` for `blueprint` partial update, which was unable to handle `datatypes.JSON` or `json.RawMessage`.
   
   This fix enhanced the `helper.DecodeMapStruct` to handle the situation, and replaced mapstructure.Decode with it.
   
   ### Does this close any open issues?
   Closes #2658 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 merged pull request #2660: fix: patch /blueprints/:id wouldn't handle byte[]

Posted by GitBox <gi...@apache.org>.
warren830 merged PR #2660:
URL: https://github.com/apache/incubator-devlake/pull/2660


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] narrowizard commented on pull request #2660: fix: patch /blueprints/:id wouldn't handle byte[]

Posted by GitBox <gi...@apache.org>.
narrowizard commented on PR #2660:
URL: https://github.com/apache/incubator-devlake/pull/2660#issuecomment-1203360740

   LGTM, please cherry-pick this fix to `v0.12-rc2` verson.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org