You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kaxil (via GitHub)" <gi...@apache.org> on 2026/03/20 02:30:15 UTC

[PR] Fix registry explore page showing wrong provider counts and empty Top Providers [airflow]

kaxil opened a new pull request, #63961:
URL: https://github.com/apache/airflow/pull/63961

   Two bugs on the `/registry/explore/` page:
   
   1. **All category cards showed "6+ providers"** — `exploreCategoryProviders.js` capped keyword matching at 6 per category, then the template appended "+". Every category with ≥6 matches displayed the same "6+" count, making it look like there aren't many providers. Removed the cap so the real count is shown (6, 12, 7, etc.). The template already uses `slice(0, 6)` to limit displayed badges.
   
   2. **Top Providers section was empty, Incubating showed "0 modules"** — `explore.njk` read `provider.module_counts` from `providers.json`, which are always zeros (extract_metadata.py doesn't populate them). Other templates (provider cards, stats) already use `moduleCountsByProvider` which computes counts from `modules.json`. Switched explore.njk to use the same source.
   
   **Before**
   <img width="1128" height="803" alt="image" src="https://github.com/user-attachments/assets/5459317a-9525-4f77-86d3-e0e7f0e8c933" />
   
   **After**
   <img width="842" height="744" alt="image" src="https://github.com/user-attachments/assets/aae3bda9-8f00-4a9b-abfc-030483047db1" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix registry explore page showing wrong provider counts and empty Top Providers [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #63961:
URL: https://github.com/apache/airflow/pull/63961


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix registry explore page showing wrong provider counts and empty Top Providers [airflow]

Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #63961:
URL: https://github.com/apache/airflow/pull/63961#discussion_r2963931487


##########
registry/src/explore.njk:
##########
@@ -59,7 +59,7 @@ mainClass: explore-page
         <div class="provider-list">
           {% set topProviders = [] %}
           {% for provider in providers.providers %}
-            {% set counts = provider.module_counts or {} %}
+            {% set counts = moduleCountsByProvider[provider.id] or {} %}
             {% set totalMods = (counts.operator or 0) + (counts.hook or 0) + (counts.sensor or 0) + (counts.trigger or 0) + (counts.transfer or 0) %}

Review Comment:
   does it require additional modules like bundle , notifiers that are in types file to count in totalMods?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix registry explore page showing wrong provider counts and empty Top Providers [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #63961:
URL: https://github.com/apache/airflow/pull/63961#discussion_r2963952691


##########
registry/src/explore.njk:
##########
@@ -59,7 +59,7 @@ mainClass: explore-page
         <div class="provider-list">
           {% set topProviders = [] %}
           {% for provider in providers.providers %}
-            {% set counts = provider.module_counts or {} %}
+            {% set counts = moduleCountsByProvider[provider.id] or {} %}
             {% set totalMods = (counts.operator or 0) + (counts.hook or 0) + (counts.sensor or 0) + (counts.trigger or 0) + (counts.transfer or 0) %}

Review Comment:
   It does count it be default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org