You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Chris Suich <ch...@netapp.com> on 2013/08/02 15:38:00 UTC

Re: Review Request 13131: Default field identifier

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13131/
-----------------------------------------------------------

(Updated Aug. 2, 2013, 1:38 p.m.)


Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.


Repository: cloudstack-git


Description
-------

Currently, the identifying value of json objects is assumed to be 'id' or 'name' (if 'id' doesn't exist). I have added the option of allowing fields to specify which json property should be the identifying value of an object.

For some reason, it says that ui/scripts/ui/dialog.js can not be found in the repository, so I have added the patch file manually. Please let me know if there is some way to fix this.


Diffs
-----


Diff: https://reviews.apache.org/r/13131/diff/


Testing
-------


File Attachments
----------------


  https://reviews.apache.org/media/uploaded/files/2013/07/31/field-identify-value.patch


Thanks,

Chris Suich

Re: Review Request 13131: Default field identifier

Posted by Brian Federle <br...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13131/#review25155
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Federle


On Aug. 2, 2013, 1:38 p.m., Chris Suich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13131/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 1:38 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently, the identifying value of json objects is assumed to be 'id' or 'name' (if 'id' doesn't exist). I have added the option of allowing fields to specify which json property should be the identifying value of an object.
> 
> For some reason, it says that ui/scripts/ui/dialog.js can not be found in the repository, so I have added the patch file manually. Please let me know if there is some way to fix this.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/13131/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   https://reviews.apache.org/media/uploaded/files/2013/07/31/field-identify-value.patch
> 
> 
> Thanks,
> 
> Chris Suich
> 
>